8000 Add new `await()` function (import from clue/reactphp-block) by clue · Pull Request #8 · reactphp/async · GitHub
[go: up one dir, main page]
Skip to content

Add new await() function (import from clue/reactphp-block) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintaine 8000 rs and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2021
Merged

Add new await() function (import from clue/reactphp-block) #8

merged 5 commits into from
Oct 21, 2021

Conversation

clue
Copy link
Member
@clue clue commented Oct 21, 2021 •
edited
Loading

This changeset adds a new await() function (imported from clue/reactphp-block v1.5.0):

try {
    $result = React\Async\await($promise);
    // promise successfully fulfilled with $result
    echo 'Result: ' . $result;
} catch (Throwable $e) {
    // promise rejected with $e
    echo 'Error: ' . $e->getMessage();
}

Most notably, this function makes it much easier to integrate async code in blocking code bases, such as test suites. On top of this, I hear there's also something new in the pipeline already to make this more useful also for long-running applications 🤫

Note that this function will assume control over the event loop. Internally, it will actually run() the loop until the promise settles and then calls stop() toterminate execution of the loop. This means this function is more suited for short-lived promise executions when using promise-based APIs is not feasible. For long-running applications, using promise-based APIs by leveraging chained then() calls is usually preferable.

Builds on top of clue/reactphp-block#57, clue/reactphp-block#59, clue/reactphp-block#60 and others
Also builds on top of #7 and #4

clue added 2 commits October 21, 2021 13:43
@clue
Import await() function from clue/reactphp-block v1.5.0
97770fa 
Change namespace from `Clue\React\Block` to `React\Async` and update all
tests with merged namespaces.

See https://github.com/clue/reactphp-block for original repo.
@clue
Remove deprecated $timeout argument
3422dad
@clue clue added the new feature New feature or request label Oct 21, 2021
@clue clue added this to the v2.0.0 milestone Oct 21, 2021
@clue clue requested a review from WyriHaximus October 21, 2021 13:06
@WyriHaximus WyriHaximus merged commit 98ae760 into reactphp:main Oct 21, 2021
@clue clue deleted the await branch October 22, 2021 04:44
@clue clue mentioned this pull request Nov 5, 2021
Closed
@clue clue mentioned this pull request Nov 15, 2021
Merged
@clue clue mentioned this pull request Feb 2, 2022
Closed
@SimonFrings SimonFrings mentioned this pull request Sep 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @WyriHaximus @SimonFrings
0