8000 Update to react 16 by BookOfGreg · Pull Request #792 · reactjs/react-rails · GitHub
[go: up one dir, main page]
Skip to content

Update to react 16 #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 9, 2017
Merged

Update to react 16 #792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
dccc8de
Correct all deprecation warnings in addons
BookOfGreg Sep 27, 2017
373f45a
Update React and React-dom to 16
BookOfGreg Sep 27, 2017
68c9ed2
Prebundle React16 and new addons
BookOfGreg Sep 27, 2017
c616ee5
Update generator to React 16 proptypes and ES6 export
BookOfGreg Sep 29, 2017
c87d890
Include react-create-class in generator for non-es6
BookOfGreg Sep 29, 2017
3cf34fb
Update test fixtures to use createReactClass
BookOfGreg Sep 29, 2017
cb66e31
Migrate more tests to React16, add createReactClass to dummyw3
BookOfGreg Sep 30, 2017
7e450ab
Add reactCreateBuild to addons
BookOfGreg Sep 30, 2017
32c9df3
Replace therubyracer with mini_racer
BookOfGreg Sep 30, 2017
e594694
Add PropTypes to default react bundle
BookOfGreg Sep 30, 2017
896b4fc
Update README on PropType
BookOfGreg Sep 30, 2017
6b0b878
Webpacker error changed, dont yell at JS errors
BookOfGreg Sep 30, 2017
57f7adc
Stop scanning for React in JSX
BookOfGreg Sep 30, 2017
61462c5
Merge update-to-chromedriver-for-js-tests into update-to-react-16
BookOfGreg Sep 30, 2017
aa65c48
Replace React.DOM with React.createElement
BookOfGreg Sep 30, 2017
4b73b9f
Add Proptypes to React with addons
BookOfGreg Oct 1, 2017
8ab2c7b
Remove Addons distributables
BookOfGreg Oct 1, 2017
1ba1110
Stop checking for reactid as createElement doesnt make one
BookOfGreg Oct 1, 2017
18faeed
Remove final references to React.createClass
BookOfGreg Oct 1, 2017
a8a9cd2
Give Webpacker ES6 import always
BookOfGreg Oct 1, 2017
8883be9
Dont reference react where it can be compiled
BookOfGreg Oct 1, 2017
691d2aa
Touch a file after a second to make it compile on fast computers
BookOfGreg Oct 1, 2017
0c1e60c
Merge resolved
BookOfGreg Oct 2, 2017
d7adca6
Reorder appraisal file so I get the most interesting failures first
BookOfGreg Oct 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include react-create-class in generator for non-es6
  • Loading branch information
@BookOfGreg
BookOfGreg committed Sep 29, 2017
commit c87d89032866111cccc8209cf1efd9f2be211588
2 changes: 1 addition & 1 deletion lib/generators/react/component_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def file_header
if options[:es6]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it important to distinguish between these two varieties of preprocessed JS? I mean, what's the scenario where you want require(...) but not import?

Anyone who's using webpacker will probably already use Babel (for JSX), right? So do you think one of these options would be sufficient by itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tempted to scrap all the old style generators but was not sure on the effect it would have with sprockets + babel transpiler. I did what looked safe given I still don't fully know the system and saw the option[:es6] used nearby in the same file.
Will continue on this path a little this afternoon, seems like the most pressing issue for now, then maybe the HMR ( 793 ) thing after once I get time.

%|import React from "react"\nimport PropTypes from "prop-types"\n|
else
%|var React = require("react")\nvar PropTypes = require("prop-types")\n|
%|var React = require("react")\nvar PropTypes = require("prop-types")\nvar createReactClass = require('create-react-class');|
end
else
''
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/templates/component.js.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<%= file_header %>var <%= component_name %> = React.createClass({
<%= file_header %>var <%= component_name %> = createReactClass({
<% if attributes.size > 0 -%>
propTypes: {
<% attributes.each_with_index do |attribute, idx| -%>
Expand Down
0