feat: add leading underscores to typeParameter name#1641
Merged
glennawatson merged 1 commit intoreactiveui:mainfrom Feb 17, 2024
Merged
feat: add leading underscores to typeParameter name#1641glennawatson merged 1 commit intoreactiveui:mainfrom
typeParameter name#1641glennawatson merged 1 commit intoreactiveui:mainfrom
Conversation
typeParameter name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 33 33
Lines 2348 2348
Branches 294 294
=======================================
Hits 2060 2060
Misses 208 208
Partials 80 80 ☔ View full report in Codecov by Sentry. |
glennawatson
approved these changes
Feb 17, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added leading underscores to
typeParameterto be inline with the other variables (______argumentsand______func).Should prevent a scenario where the name is already used in the interface.