feat: implement typed Input/Output interface for resolvers #753
+1,471
−581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisre
commented
Feb 26, 2025
jorisre
commented
Mar 3, 2025
This was referenced Mar 6, 2025
Closed
|
@jorisre I believe I made some progress on the types here, in #755 and in react-hook-form/react-hook-form#12664 Let me know how it looks to you |
1 task
|
Size Change: +1.72 kB (+3.17%) Total Size: 55.8 kB
ℹ️ View Unchanged
|
kotarella1110
previously approved these changes
Mar 27, 2025
Appreciate your help, thanks again! |
bluebill1049
approved these changes
Mar 27, 2025
bluebill1049
previously approved these changes
Mar 31, 2025
The base branch was changed.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
spiftire
reviewed
Apr 1, 2025
| @@ -11,7 +11,7 @@ | |||
| "types": "dist/index.d.ts", | |||
| "license": "MIT", | |||
| "peerDependencies": { | |||
| "react-hook-form": "^7.0.0", | |||
| "react-hook-form": "7.55.0", | |||
There was a problem hiding this comment.
Should this be locked to version 7.55.0?
Suggested change
| "react-hook-form": "7.55.0", | |
| "react-hook-form": "^7.55.0", |
huynhducduy
reviewed
May 17, 2025
There was a problem hiding this comment.
Why do we switch from arktype native implementation to standard-schema? And why not all standard-schema-compatible resolvers follow this approach?
There was a problem hiding this comment.
Also, using this approach will lead to the resolver failing to infer the type from the schema, unless the user specifically installs @standard-schema/spec as their dependency
There was a problem hiding this comment.
apologize for mentioning you guys @jorisre @bluebill1049 @kotarella1110
There was a problem hiding this comment.
We switched to standard-schema from the native arktype implementation because type inference in Arktype wasn't working as expected. But if you've found a solid solution, we're happy to review a PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements typed Input/Output interfaces for resolvers, which needs react-hook-form/react-hook-form#12638
Next steps will involve extending this implementation to all applicable resolver modules.
Note: This PR will fail until the release of react-hook-form/react-hook-form#12638
Fixes #743