feat: add better ESM support #6939
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to modernize the codebase and improve compatibility with ES modules. The most significant updates include switching from CommonJS to ES module syntax, adding the
"type": "module"field inpackage.json, and updating dependencies. Additionally, import paths across multiple files have been updated to explicitly include.jsextensions for better module resolution.Modernization of module system:
.babelrc.js: Replacedmodule.exportswithexport defaultto align with ES module syntax.package.json: Added"type": "module"to indicate the use of ES modules.package.json: Removed the creation ofpackage.jsonfiles with"type"fields during build scripts, as the"type": "module"field now applies globally.Dependency updates:
package.json: Updated@restart/uito version^2.0.0-beta.5anddom-helpersto version^6.0.1for improved functionality and compatibility.Import path updates:
src/AbstractModalHeader.tsx,src/Accordion.tsx,src/Alert.tsx, etc.) to include.jsextensions explicitly, ensuring compatibility with ES modules. Examples include:src/AbstractModalHeader.tsx: Changed imports forCloseButtonandModalContextto include.jsextensions.src/Accordion.tsx: Updated imports forAccordionBody,AccordionButton,AccordionCollapse, and others to include.jsextensions.src/Alert.tsx: Updated imports forAlertHeading,AlertLink,Fade, and others to include.jsextensions.