8000 fix: invalid relative path between Navs & Tabs documents by TechQuery · Pull Request #6936 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]
Skip to content

fix: invalid relative path between Navs & Tabs documents #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: invalid relative path between Navs & Tabs documents #6936

wants to merge 1 commit into from

Conversation

TechQuery
Copy link

@kyletsang
Copy link
Member

Thanks for the PR. The checks are failing though, could you look into it?

@TechQuery
Copy link
Author

The checks are failing though, could you look into it?

I'm not a Docusaurus user, I can't understand its Path Resolution logic:

Exhaustive list of all broken links found:
  - Broken link on source page path = /docs/components/navs:
     -> linking to ../tabs (resolved as: /docs/tabs)
  • before: ./tabs resolved as /docs/components/navs/tabs
  • after: ../tabs resolved as /docs/tabs

it doesn't make sense!

@kyletsang
Copy link
Member

I double checked the website and I see the link is working correctly. Where are you getting "https://react-bootstrap.github.io/docs/components/navs/tabs" from?

@TechQuery
Copy link
Author

I double checked the website and I see the link is working correctly. Where are you getting "https://react-bootstrap.github.io/docs/components/navs/tabs" from?

The wrong link is just under the "Tabs" title:
https://react-bootstrap.github.io/docs/components/navs/#tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TechQuery @kyletsang
0