Add CJS to exports map #6919
Open
Add CJS to exports map #6919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Will try to address as much as I can for the next major, so won't merge this for now. |
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was called out in #6901 that the ESM build of this package is really only "faux" ESM; that is,
importstatements don't use fully-qualified paths with extensions, which is required for runtimes like Node. The addition of"exports"topackage.jsonin #6901 poses a compatibility issue if this package continues shipping faux ESM: this package will be unusable in Node applications that are using native ESM. If one tries to import something likereact-bootstrap/Cardin such an application, one will see the following error:A workaround would be to directly import the CJS files, e.g.
react-bootstrap/cjs/Card.js, but trying to do that on currentmasterfails with the following:This is expected, but leaves consumers of this package without any option to work around the faux ESM issue.
I'm opening this PR to give folks in this situation an escape hatch: they can explicitly use the CJS build with something like the following:
If you plan on resolving the faux ESM issue before the release of
"exports"inpackage.json, you can safely disregard this PR.