8000 fix: resolve no-promise-executor-return linting error by anusha-c18 · Pull Request #6856 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]
Skip to content

fix: resolve no-promise-executor-return linting error #6856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: resolve no-promise-executor-return linting error #6856

merged 1 commit into from
Nov 18, 2024

Conversation

anusha-c18
Copy link
Contributor

This PR fixes the no-promise-executor-return linting error in the simulateNetworkRequest function.

As arrow functions are shown as an example of incorrect code in the rule docs, wrapping the code in curly braces makes the intent more clear and doesn't throw a linting error.

@anusha-c18 anusha-c18 mentioned this pull request Nov 12, 2024
Open
@kyletsang kyletsang merged commit b5c8d22 into react-bootstrap:master Nov 18, 2024
4 checks passed
@kyletsang
Copy link
Member

Thanks

@anusha-c18 anusha-c18 deleted the fix-no-promise-executor-return branch November 26, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anusha-c18 @kyletsang
0