8000 fix(Nav): remove prop-types-extra import from build by kyletsang · Pull Request #6854 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]

Skip to content

fix(Nav): remove prop-types-extra import from build #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kyletsang
Copy link
Member

Fixes #6830

The import wasn't removed due to how we declared additionalLibraries for babel-plugin-transform-react-remove-prop-types. It was looking for an exact import path.

https://github.com/react-bootstrap/configs/blob/99ab44dd872eee57d495f188dadee98608a03d23/packages/babel-preset/index.js#L48

@kyletsang kyletsang merged commit ab81d6b into master Nov 15, 2024
10 checks passed
@kyletsang kyletsang deleted the fix-proptypes-all branch November 15, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to build with Vite 5 + Rollup + StoryBook 8 cause as the reason of prop-types-extra importing
1 participant
0