8000 docs: fixed mistake with grid example by zarzas980 · Pull Request #6826 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]
Skip to content

docs: fixed mistake with grid example #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

docs: fixed mistake with grid example #6826

merged 1 commit into from
Jul 23, 2024
+2 −2

Conversation

zarzas980
Copy link
Contributor

Error in the "Grid" docs.

The example in the documentation for ordering suggest that the order property takes a value between 1 and 12 (inclusive). However, that is not working properly in the example.

The Bootstrap "documentation" says the range goes from 0 to 5 (inclusive). I changed the values in the example to those two.

@zarzas980
docs: fixed mistake with grid example
e433aea 
Error in the ["Grid"](https://react-bootstrap.netlify.app/docs/layout/grid/#responsive-grids)

The example in the documentation suggest that the `order` property takes a value between `1` and `12` (inclusive). It is not working properly in the example.

The Bootstrap ["documentation"](https://getbootstrap.com/docs/5.3/utilities/flex/#order) says the range goes from `0` to `5` (inclusive).
@kyletsang kyletsang merged commit 0952140 into react-bootstrap:master Jul 23, 2024
4 checks passed
@kyletsang
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarzas980 @kyletsang
0