8000 fix: switch from defaultProps to JS default params by madflow · Pull Request #6823 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]
Skip to content

fix: switch from defaultProps to JS default params #6823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: bs4-dev
Choose a base branch
from
Open

fix: switch from defaultProps to JS default params #6823

wants to merge 1 commit into from

Conversation

madflow
Copy link
@madflow madflow commented Jul 2, 2024
  • We are using 3rd Party Integrations which only support BS4
  • We would like to use React 18.3 without warnings
  • I tinkered with the prop types and basically went over the low hanging fruit (as far as I can tell :S)
  • I have read Remove defaultProps for React 18.3.0 #6547 , maybe we can make some small changes and make it a little bit better for BS4?

@madflow madflow force-pushed the bs4-default-props branch from fb3c257 to 4471cc9 Compare July 2, 2024 16:07
@madflow madflow force-pushed the bs4-default-props branch from 4471cc9 to b2bdae6 Compare July 3, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madflow
0