8000 Update Fade.tsx - element.ref is now a regular prop by BOXNYC · Pull Request #6820 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]
Skip to content

Update Fade.tsx - element.ref is now a regular prop #6820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update Fade.tsx - element.ref is now a regular prop #6820

merged 1 commit into from
Jul 23, 2024

Conversation

BOXNYC
Copy link
Contributor
@BOXNYC BOXNYC commented Jun 23, 2024

In React >= 19, accessing element.ref is no longer supported and ref has become a regular prop. It will be removed from the JSX Element type in a future release.

Replaced .ref with .props.ref for React version 19+.

@BOXNYC
Update Fade.tsx
90205f2 
In React >= 19, accessing element.ref is no longer supported and ref has become a regular prop. It will be removed from the JSX Element type in a future release.

Replaced .ref with .props.ref for React version 19+.
@BOXNYC BOXNYC mentioned this pull request Jun 24, 2024
Closed
@kyletsang kyletsang merged commit 9b8bcd7 into react-bootstrap:master Jul 23, 2024
10 checks passed
@kyletsang
Copy link
Member

Thanks

@BOXNYC
Copy link
Contributor Author
BOXNYC commented Sep 26, 2024

Can you please push to npm? :)

@kyletsang
Copy link
Member

Hey sorry about that, this slipped my mind. It's published now: v2.10.5

@BOXNYC
Copy link
Contributor Author
BOXNYC commented Sep 26, 2024

No worries, thanks for maintaining this!!

@it21222672 it21222672 mentioned this pull request Oct 18, 2024
Open
@sswietoniowski sswietoniowski mentioned this pull request Oct 22, 2024
Merged
@mooseburgr mooseburgr mentioned this pull request Oct 25, 2024
Closed
@Victor-Nash Victor-Nash mentioned this pull request Oct 27, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Oct 29, 2024
Open
@samrouth1234 samrouth1234 mentioned this pull request Oct 29, 2024
Open
@thedignifiedco thedignifiedco mentioned this pull request Oct 31, 2024
Open
@scudette scudette mentioned this pull request Oct 31, 2024
Closed
@leoo1992 leoo1992 mentioned this pull request Oct 31, 2024
Open
@samrouth1234 samrouth1234 mentioned this pull request Nov 1, 2024
Open
@han20011222 han20011222 mentioned this pull request Nov 1, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 3, 2024
Open
@zxcv32 zxcv32 mentioned this pull request Nov 4, 2024
Open
@MadisonEvans94 MadisonEvans94 mentioned this pull request Nov 5, 2024
Open
@timtucker-dte timtucker-dte mentioned this pull request Nov 7, 2024
Closed
3 tasks
@zxcv32 zxcv32 mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BOXNYC @kyletsang
0