Use new path constants #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,8 +3,9 @@ import path from 'path'; | |||
| import fsp from 'fs-promise'; | |||
| import semver from 'semver'; | |||
| import { safeExec } from '../exec'; | |||
| import { repoRoot } from './constants'; | |||
There was a problem hiding this comment.
constants is actually up one more directory from here.
|
Other than the module import location reference everything looks great. After those are cleaned up, we will still need sign off from another collaborator @react-bootstrap/collaborators |
|
Looks like a rebase is needed. Other than that, LGTM 👍 |
mtscout6
added a commit
that referenced
this pull request
Apr 27, 2015
The constants module was moved up one directory. This finalizes #576.
|
I fixed the imports and merge conflicts. |
|
👍 |
|
Thanks for fixing it up for me @mtscout6 |
73E4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you suggested in my other pull request (#536) the
src/root folder was a good candidate to add to constants. I also added constants for other folders which simplified the build files. Since I took it a bit further I thought it better to create a separate PR.