fix small things #12
Merged
fix small things #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
10 tasks
|
this looks great thanks so much. One question why did you make ffmpegg local only 25 char? |
I assumed that they were the same (ffmpeg cli was 25 also i think)? |
|
I think ffmpeg_cli is the command which should be in the container's path but ffmpegg local I think can be the full path the executable. I'll merge it in and see if something breaks on my end. Do you also want to use ffmpeg for transcoding? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix some code review things, though I havent tested it because I dont have an environment to test it in.