8000 Add Zata storage by Samarth1015 · Pull Request #8613 · rclone/rclone · GitHub
[go: up one dir, main page]
Skip to content

Add Zata storage #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add Zata storage #8613

wants to merge 15 commits into from

Conversation

Samarth1015
Copy link
@Samarth1015 Samarth1015 commented Jun 18, 2025 •
edited
Loading

What is the purpose of this change?

Was the change discussed in an issue or in the forum before?

Yes, but due to some other error i am raising a new PR for review.
I have a PR #8602 which by mistakenly got so many line of code changed.
you can review commit d2ff7ae in that PR.
Thanks .

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

@Samarth1015
Copy link
Author

Hello , is there any command which do solve the lint error in file?

@Samarth1015
Copy link
Author
Samarth1015 commented Jun 18, 2025 •
edited
Loading

All the wokflow tests are passing , you can review the code .
Thank You.
image

@Samarth1015
Copy link
Author
Samarth1015 commented Jun 18, 2025 •
edited
Loading

This commit a2fc65d workflow is passing all the tests. Please approve for the workflow @albertony .
Thanks.

@Samarth1015
Copy link
Author

@albertony Completed the workflow with all checks passed, what will be the next thing to do ?
Thanks.

@albertony
Copy link
Contributor

Great! Now you'll just have to wait for someone taking the time to do a proper code review.

@Samarth1015 Samarth1015 mentioned this pull request Jun 18, 2025
Closed
ncw
ncw requested changes Jun 19, 2025
View reviewed changes
Copy link
Member
@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better :-)

I put some comments inline, mostly about the docs.

Please update this PR (don't create a new one). You can add a commit to your branch and then push it and the PR will update. I will squash the commits before merge.

Thank you

@Samarth1015
Copy link
Author

Thanks for the review @ncw , I have made the requested changes. Please have a look.
Thanks.

@Samarth1015 Samarth1015 requested a review from ncw June 19, 2025 13:39
@Samarth1015
Copy link
Author

@ncw can you please have a look on why workflow is failing on windows because it was successfully passing in earlier commit . According to me its a zip error (can you have a look on it).
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw Awaiting requested review from ncw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Samarth1015 @albertony @ncw
0