http: add metadata support for the backend #8603
Conversation
|
@ncw It's ready for review. |
There was a problem hiding this comment.
Code looks great :-)
There are a few things missing for full metadata support
The metadata docs like this: https://rclone.org/s3/#metadata are auto generated by a Metadata info block
Lines 222 to 225 in 3cae373
So the http backend needs one too.
I think you need to adjust the Feature flags also, eg
Line 3827 in 3cae373
And in turn the overview for the http backend (see metadata column)
https://github.com/rclone/rclone/blob/master/docs/content/overview.md
I think the http serve docs should probably mention that if --metadata is in use then these keys will be served as these headers etc...
Super job - thanks!
|
Hi @ncw ! I've applied the suggested changes - thank you for the review. P.S. I don't think the failed windows build is related to my changes. |
What is the purpose of this change?
The objective is to extract the file name from the content-disposition header. This name should replace the one in stat, and a content-disposition handler should be provided via serve.
Was the change discussed in an issue or in the forum before?
#8298
Checklist
P.S.:
Recreation of: #8413