drive: fixed the issue where Google Docs file name was truncated, causing panic or unparseable characters #8573
Conversation
| @@ -1495,7 +1495,7 @@ func (f *Fs) NewObject(ctx context.Context, remote string) (fs.Object, error) { | |||
| return nil, err 8000 | |||
| } | |||
|
|
|||
| remote = remote[:len(remote)-len(extension)] | |||
| remote = strings.TrimSuffix(remote, extension) | |||
There was a problem hiding this comment.
I think this must be a bug in f.getRemoteInfoWithExport(ctx, remote) - why is it returning extension if remote doesn't have extension?
…sing panic or unparseable characters When downloading Google documents, the remote does not contain the suffix, and the extension is '.docx'. The code here will cause panic or the file name will be truncated (if the file name is Chinese or Japanese, there will be unparseable characters)
Sorry, it turns out the issue was caused by our modification to the list behavior. In our version, the listed Google Docs use the original file name without appending the .docx extension. However, in the native rclone implementation, Google Docs are listed with the .docx extension appended, which avoids the error. |
|
Ah that makes sense. Do you want to merge this anyway? It seems like good defensive programming. |
Yes, I think it would be better to merge this. Thank you. |
What is the purpose of this change?
When downloading Google documents, the remote does not contain the suffix, and the extension is '.docx'. The code here will cause panic or the file name will be truncated (if the file name is Chinese or Japanese, there will be unparseable characters)
Was the change discussed in an issue or in the forum before?
Checklist