10000 docs: fix typos by kovaacs · Pull Request #8568 · rclone/rclone · GitHub
[go: up one dir, main page]

Skip to content

docs: fix typos #8568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: fix typos #8568

wants to merge 2 commits into from

Conversation

kovaacs
Copy link
@kovaacs kovaacs commented May 25, 2025

What is the purpose of this change?

Was the change discussed in an issue or in the forum before?

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

Copy link
Contributor
@albertony albertony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Several of the changes are in autogenerated files, though. If you revert those, I can merge it.

This is to some degree documented in the contributing guide:

The MANUAL.*, rclone.1, website, etc. are all auto-generated from those during the release process

However I totally understand it is easy to miss. Luckily, we do have a lint check for this now, so if I had approved the workflows to run it would have reported it automatically. I though I'd just save a 🌳 and report it manually..

@kovaacs
Copy link
Author
kovaacs commented May 29, 2025

I reverted the files, but now the issues I wanted to fix are no longer in my PR. If those files are autogenerated, then how do the typos appear in the docs?

@kovaacs
Copy link
Author
kovaacs commented May 29, 2025

Okay, so what I wanted to fix was already fixed: b1d4de6#diff-97086aa7b268bacc1edc02a7f44788142a45a504b6fec5a0f0d8557273571361L387

However, the website is showing the faulty version:
Screenshot 2025-05-29 at 14 28 58

@albertony
Copy link
Contributor

Right. The official http://rclone.org docs updates according to releases, but there is a http://tip.rclone.org site which are based on latest master.

@@ -389,7 +389,7 @@ Use the gphotosdl proxy for downloading the full resolution images
The Google API will deliver images and video which aren't full
resolution, and/or have EXIF data missing.

However if you use the gphotosdl proxy then you can download original,
However, if you use the gphotosdl proxy, then you can download original,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is also autogenerated. Ref this line above:

{{< rem autogenerated options start" - DO NOT EDIT - instead edit fs.RegInfo in backend/googlephotos/googlephotos.go then run make backenddocs" >}}

(I was sure I noted this in my initial review, but seems that comment was lost, sorry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0