-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
docs: fix typos #8568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: fix typos #8568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Several of the changes are in autogenerated files, though. If you revert those, I can merge it.
This is to some degree documented in the contributing guide:
The MANUAL.*, rclone.1, website, etc. are all auto-generated from those during the release process
However I totally understand it is easy to miss. Luckily, we do have a lint check for this now, so if I had approved the workflows to run it would have reported it automatically. I though I'd just save a 🌳 and report it manually..
I reverted the files, but now the issues I wanted to fix are no longer in my PR. If those files are autogenerated, then how do the typos appear in the docs? |
Okay, so what I wanted to fix was already fixed: b1d4de6#diff-97086aa7b268bacc1edc02a7f44788142a45a504b6fec5a0f0d8557273571361L387 |
Right. The official http://rclone.org docs updates according to releases, but there is a http://tip.rclone.org site which are based on latest master. |
@@ -389,7 +389,7 @@ Use the gphotosdl proxy for downloading the full resolution images | |||
The Google API will deliver images and video which aren't full | |||
resolution, and/or have EXIF data missing. | |||
|
|||
However if you use the gphotosdl proxy then you can download original, | |||
However, if you use the gphotosdl proxy, then you can download original, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is also autogenerated. Ref this line above:
{{< rem autogenerated options start" - DO NOT EDIT - instead edit fs.RegInfo in backend/googlephotos/googlephotos.go then run make backenddocs" >}}
(I was sure I noted this in my initial review, but seems that comment was lost, sorry)
What is the purpose of this change?
Was the change discussed in an issue or in the forum before?
Checklist