8000 pico_cyw43_driver/cyw43_bus_pio_spi.c: make SPI_PROGRAM_NAME and CLOC… by mvds00 · Pull Request #1499 · raspberrypi/pico-sdk · GitHub
[go: up one dir, main page]
Skip to content

pico_cyw43_driver/cyw43_bus_pio_spi.c: make SPI_PROGRAM_NAME and CLOC… #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2024
Merged

pico_cyw43_driver/cyw43_bus_pio_spi.c: make SPI_PROGRAM_NAME and CLOC… #1499

merged 1 commit into from
Jun 21, 2024

Conversation

mvds00
Copy link
Contributor
@mvds00 mvds00 commented Sep 8, 2023

Fixes #1498

This patch allows to override the default value for SPI_PROGRAM_NAME and CLOCK_DIV in src/rp2_common/pico_cyw43_driver/cyw43_bus_pio_spi.c by defining CYW43_SPI_PROGRAM_NAME and/or CYW43_PIO_CLOCK_DIV.

This is useful when other cpu speeds are involved, e.g. running the Pi Pico W at 12 MHz from xosc.

@matsobdev
Copy link
matsobdev commented Oct 20, 2023 •
edited
Loading

It would be nice to have full range of cpu speeds at runtime for Pico W.

@mvds00
Copy link
Contributor Author
mvds00 commented Oct 21, 2023

I fully agree @matsobdev, the potential for power efficient applications is huge. But it involves a lot of changes. Running from xosc at 12 MHz with pll_sys disabled for example, is currently not possible using build settings alone. I think the first step in having the full range of cpu speeds available, would be to make the cpu speed and everything depending on it configurable at build time.

@lurch lurch mentioned this pull request Oct 22, 2023
Closed
@ai6aj
Copy link
ai6aj commented Oct 22, 2023 •
edited
Loading

See also #1521 which allows the default clock divisor to be overridden at runtime, which is useful for Micropython etc. Both patches look like they can merge with each other without issue.

CEBD
@peterharperuk peterharperuk self-assigned this Jan 12, 2024
kilograham
kilograham reviewed May 19, 2024
View reviewed changes
Copy link
Contributor
@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a PICO_CONFIG comment so it is added to the docs

@kilograham kilograham added this to the 1.5.2 milestone May 19, 2024
@kilograham kilograham merged commit f5fea7f into raspberrypi:develop Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilograham kilograham kilograham approved these changes

Assignees

@peterharperuk peterharperuk

Labels
cyw43_driver
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mvds00 @matsobdev @ai6aj @kilograham @peterharperuk
0