8000 drm/tiny: Add support for Mayqueen Pixpaper e-ink panel by lc-wang · Pull Request #6931 · raspberrypi/linux · GitHub
[go: up one dir, main page]
Skip to content

drm/tiny: Add support for Mayqueen Pixpaper e-ink panel #6931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: rpi-6.16.y
Choose a base branch
from
Open

drm/tiny: Add support for Mayqueen Pixpaper e-ink panel #6931

wants to merge 3 commits into from
+831 −0

Conversation

lc-wang
Copy link
@lc-wang lc-wang commented Jul 2, 2025

This series adds support for the Mayqueen Pixpaper e-ink display panel, controlled via SPI.

The series includes:

  • A vendor 8000 -prefix entry for "mayqueen"
  • Device tree binding documentation for the Pixpaper panel
  • A new DRM tiny driver using the simple KMS helper framework

Panel specs:

  • Resolution: 122x250
  • Format: XRGB8888
  • Interface: SPI

The driver has been tested on:

  • Raspberry Pi 2 Model B
  • Linux kernel 6.16

All patches are signed off and follow the existing DRM/tiny structure. The goal is to provide a lightweight, open-source reference driver for integrating small e-paper displays in embedded systems using the DRM subsystem.

Tested-by: LiangCheng Wang zaq14760@gmail.com
Signed-off-by: LiangCheng Wang zaq14760@gmail.com
Co-developed-by: Wig Cheng onlywig@gmail.com

wigcheng and others added 3 commits July 2, 2025 14:27
@wigcheng @lc-wang
dt-bindings: vendor-prefixes: Add Mayqueen name
37a8d71 
Mayqueen is a Taiwan-based company primarily focused on the development
of arm64 development boards and e-paper displays.

Signed-off-by: Wig Cheng <onlywig@gmail.com>
@lc-wang
drm: tiny: Add support for Mayqueen Pixpaper e-ink panel
7ce7264 
Introduce a DRM driver for the Mayqueen PIxpaper e-ink display panel,
which iscontrolled via SPI. The driver supports a 122x250 resolution
display with XRGB8888 format, using the DRM simple KMS helper framework.

Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
@lc-wang
dt-bindings: display: Add Mayqueen Pixpaper e-ink panel
945b7bc 
The binding is for the Mayqueen Pixpaper e-ink display panel,
controlled via an SPI interface.

Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
@6by9
Copy link
Contributor
6by9 commented Jul 2, 2025

This series really wants to go upstream to the dri-devel mailing list for review, particularly as it's missing a dtoverlay to make it useful on a Raspberry Pi.

I can make a couple of comments based on a very quick read through:

  • Whilst other tinydrm drivers are using drm_simple_display_pipeline, recent guidance has been not to use it as it is viewed as an unneeded layer of indirection. https://lore.kernel.org/dri-devel/61d317d3-d6dd-4b9c-bf2b-4d5aa51f60bd@suse.de/
  • Handling around init_completed_successfully looks suspicious. It shouldn't be possible to call update before init is complete.
  • SPI drivers need a struct spi_device_id table as well as the compatible string match table, otherwise you'll get a warning logged from https://elixir.bootlin.com/linux/v6.15.4/source/drivers/spi/spi.c#L487
  • Having a load of vmap type operations in there makes me think something may be off, but it may be necessary for this display. UDL is a different display that needs to do similar packing of image buffers, and that doesn't have to do similar mappings.

Hope that helps.

@lc-wang
Copy link
Author
lc-wang commented Jul 3, 2025

Understood, thank you for the clarification.

I'll prioritize getting this driver upstream first, following the suggestions you gave. Once it lands upstream or gets reviewed, I can revisit integration with Raspberry Pi if needed.

Thanks again for the guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lc-wang @6by9 @wigcheng
0