8000 mcp23s17 fixes by 6by9 · Pull Request #6769 · raspberrypi/linux · GitHub
[go: up one dir, main page]

Skip to content

mcp23s17 fixes #6769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: rpi-6.12.y
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pinctrl: mcp23s08: Register pinctrl before gpiochip
In order for gpio-ranges to be registered correctly, the
pinctrl device needs to be registered before the gpiochip.
The mcp23s08 driver was doing them in the opposite order.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
  • Loading branch information
6by9 committed Apr 3, 2025
commit 74d6e8487948864bf01e98d6d3fd340225ae2b17
8 changes: 4 additions & 4 deletions drivers/pinctrl/pinctrl-mcp23s08.c
Original file line number Diff line number Diff line change
Expand Up @@ -675,10 +675,6 @@ int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev,
girq->threaded = true;
}

ret = devm_gpiochip_add_data(dev, &mcp->chip, mcp);
if (ret < 0)
return dev_err_probe(dev, ret, "can't add GPIO chip\n");

mcp->pinctrl_desc.pctlops = &mcp_pinctrl_ops;
mcp->pinctrl_desc.confops = &mcp_pinconf_ops;
mcp->pinctrl_desc.npins = mcp->chip.ngpio;
Expand All @@ -692,6 +688,10 @@ int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev,
if (IS_ERR(mcp->pctldev))
return dev_err_probe(dev, PTR_ERR(mcp->pctldev), "can't register controller\n");

ret = devm_gpiochip_add_data(dev, &mcp->chip, mcp);
if (ret < 0)
return dev_err_probe(dev, ret, "can't add GPIO chip\n");

if (mcp->irq) {
ret = mcp23s08_irq_setup(mcp);
if (ret)
Expand Down
0