-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix titles redux #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix titles redux #1971
Conversation
@lurch Is this fixable? The title of the |
Not easily... 😕 |
Alternatively we could make it say "Raspberry Pi Documentation - Computers" since the "index page" is a copy of the "computers category page"? 🤷 |
That's bad for SEO. 😢 Any way to just hardwire it? |
Okay, let me try a different tactic... |
...hmmm, nope my alternative tactic: diff --git a/jekyll-assets/_layouts/docs.html b/jekyll-assets/_layouts/docs.html
index 0e187ffb..346978c8 100644
--- a/jekyll-assets/_layouts/docs.html
+++ b/jekyll-assets/_layouts/docs.html
@@ -14,7 +14,7 @@
{% include nav.html %}
<section id="content">
- <h1>{{ page.title }}</h1>
+ <h1>{{ page.sub_title }}</h1>
{{ content }}
</section>
</div>
diff --git a/scripts/create_build_adoc.py b/scripts/create_build_adoc.py
index c6796ab7..c2577e7b 100755
--- a/scripts/create_build_adoc.py
+++ b/scripts/create_build_adoc.py
@@ -30,7 +30,8 @@ if __name__ == "__main__":
out_fh.write(""":parentdir: {}
:page-layout: docs
:includedir: {}
-:doctitle: Raspberry Pi Documentation - {}
+:doctitle: {}
+:sub_title: {}
include::{{includedir}}/{{parentdir}}/{}[]
-""".format(output_path, src_dir, index_title, adoc_filename))
+""".format(output_path, src_dir, 'Raspberry Pi Documentation - {}'.format(index_title), index_title, adoc_filename)) didn't work as it ends up with the |
Okay. I'm going to merge your intial fix then (aka this PR) that fixes everything except the top level index header. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the top level title so it's "Raspberry Pi Documentation" rather than "Raspberry Pi Documentation - Index" but other than that, LGTM.
I took a lucky guess at the fix and it worked 🎉 #1980 |
No description provided.