Customer group pricing #1074
Merged
Customer group pricing #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd enabled status
…into feature/flat-tables
…ature/flat-tables
…ature/flat-tables
…ature/flat-tables
…oduct price tests
Jade-GG
previously approved these changes
Nov 14, 2025
| // TODO: Is there anything unsafe to share in here? | ||
| // Plus, maybe we could remove the GraphQL call? | ||
| // We're doing this for the customer group id | ||
| // GraphQL isn't explosing that value. |
Collaborator
There was a problem hiding this comment.
We could use Compadre for this. However, I don't know if that's too close to "requiring the use of compadre" which we don't necessarily want.
Member
Author
There was a problem hiding this comment.
Yea we don't want to require it, but not sure if this is ugly / insecure. It's working perfectly.
Collaborator
|
Can you check the tests? Or are those being checked elsewhere? |
Member
Author
|
RAP-1656 is a follow up for the tests |
indykoning
reviewed
Nov 18, 2025
Comment on lines
+66
to
+73
| userStorage.value = { | ||
| ...(await magentoGraphQL(`{ customer { ${config.queries.customer} } }`))?.data?.customer, | ||
| // TODO: Is there anything unsafe to share in here? | ||
| // Plus, maybe we could remove the GraphQL call? | ||
| // We're doing this for the customer group id | ||
| // GraphQL isn't explosing that value. | ||
| ...(await rapidezAPI('get', 'customer')), | ||
| } |
Member
There was a problem hiding this comment.
Due to both awaits here these calls are done synchronously.
We could work around this by awaiting a
const responses = Promise.all([
magentoGraphQL(`{ customer { ${config.queries.customer} } }`)).then((response) => response?.data?.customer),
rapidezAPI('get', 'customer'),
])
Or can we move this under an asyncComputed somewhere so it only does the RapidezAPI call on retrieval of the attributes the api would provide
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on 7242ce4, with this we're seeing customer group pricing in listings and the price filter is working with it. The followup is RAP-1655 to implement the sorting.
For reference for the keying: #1062