Fix: cross-version placeholder support #3463
Merged
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (893ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Contributor
|
I believe we can remove this file as well. |
…l object directly
Coverage Summary> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (853ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
kedashoe
approved these changes
May 5, 2024
Closed
|
I know this PR is merged but still we can do one more thing that is too keep both the check. So that if anyone using the latest version he gets the benifit of === and for backward compatibility lets use already existing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3458
The strict equality operator means that
_isPlacerholderworks for only theR.__from that specific install. If your project has multiple versions of ramda (which can easily happen due to npm semver resolution and^versus~versus exact inpackage.json), you'll have problems.https://github.com/ramda/ramda/pull/3388/files#diff-cfb81eb9592aa5597e5aa32c6e449214f5b7eabeb172ad2447e2e537232454d2L2-R4
Reverting the logic back to what it was before is a looser check that will work cross-version