Add a flag to deprecate config properties #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38ac427 to
a94c0a4
Compare
e787d76 to
a94c0a4
Compare
4ee37f5 to
9a54507
Compare
ketiltrout
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be helpful when modifying old tasks.
I've also added a feature to the pipeline base task to add a debug log entry if a task returns the same object as one of the inputs, which suggests that it could have been modified in place. This is mostly for my own use if I'm trying to review weird behaviour in a pipeline config, but I think it's helpful.
There's something broken in the tests from a very recent release of
numcodecs(https://numcodecs.readthedocs.io/en/stable/release.html#removals).There's already an open PR in
zarrto address it, so I'm just going to leave this PR until that gets merged, because I don't want to have to pinnumcodecsourselves. Update: this still wasn't working properly with python 3.13, so I've just pinnednumcodecs. I think we'll have to keep it pinned until we upgrade to zarr 3 anyway.