Backport: Preserve forwarded IP address for trusted proxy chains #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes proxies make requests to Rack applications, for example HAProxy health checks and so on. Previously the forwarded IP implementation ate up these IP addresses, making it hard to tell in Rack applications who made the request
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Apr 5, 2019
This update has two important fixes: 1. It reverts the monkey patch introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23385 since rack/rack#1201 is now part of the release. 2. Preserve forwarded IP address for trusted proxy chains (rack/rack#1343).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport to
2-0-stableof @SamSaffron's fix which was merged tomasterwith #1224@eileencodes @tenderlove it would be super awesome if you could make a new rack release with this backport 😊 .
Sometimes proxies make requests to Rack applications, for example
HAProxy health checks and so on.
Previously the forwarded IP implementation ate up these IP addresses,
making it hard to tell in Rack applications who made the request