E52C MAINT: Refactor prov lib to natively use Results by Oddant1 · Pull Request #884 · rachis-org/rachis · GitHub

MAINT: Refactor prov lib to natively use Results#884

Merged

colinvwood merged 98 commits intorachis-org:devfrom

Oddant1:prov-lib-refactor

Dec 23, 2025

Contributor

Oddant1 commented

closes #879

Oddant1 added 30 commits

November 3, 2025 14:06


          Checkpoint in loading Result earlier


          Ensure we have a loaded Result to parse if that's what we were given …

23c0714

…as input


          Remove accpeted_data_types fields from parsers

eb4cf81


          Checkpoint

81f5ff8


          Start rewriting _parse_pre_prov

cda96c6


          Update parse_version signature and import result

1f721c4


          Checkpoint

270174d


          Update to str(uuid) and add parse_prov abstract method

c75f42c


          Use a check that actually works to determine if Result has checksums

4d92e5a


          Update checksums test

11bbffc


          Merge branch 'dev' into prov-lib-refactor

27d8327


          Fix Metadata tests

cda5ec5


          Remove some dead code

197a8a2


          Clean up _Action and _Citations

062988f


          No more zipfile in validator

16dc9e5


          no more get root or non_root uuid

c188eb1


          Dead imports

b3042e8


          More dead import

6c4ec5e


          Remove dead tests

0608a77


          Even more dead imports

af8a77b


          More cleanup of ProvNode and associated classes

d745670


          Update ActionTests

10BC0

b9e47b7


           Refactor setting versions

ba1feda


          Update tests in test_archive_parser

90d9bc5


          Update checksum tests

156e742


          Lint

beac420


          Fix ProvNode repr

e30d8ea


          Now getting the does not exist error from archive

300259c


          This test also now getting error from archive load

f826c20


          Update test to reflect fixed ProvNode repr

9b085b1

colinvwood reviewed

View reviewed changes

qiime2/core/archive/provenance_lib/archive_parser.py Show resolved Hide resolved

colinvwood reviewed

View reviewed changes

qiime2/core/archive/provenance_lib/archive_parser.py Show resolved Hide resolved

colinvwood reviewed

View reviewed changes

qiime2/core/archive/provenance_lib/archive_parser.py Show resolved Hide resolved

colinvwood reviewed

View reviewed changes

qiime2/core/archive/provenance_lib/archive_parser.py Show resolved Hide resolved

colinvwood reviewed

View reviewed changes

qiime2/core/archive/provenance_lib/replay.py Outdated Show resolved Hide resolved

colinvwood reviewed

View reviewed changes

qiime2/sdk/usage.py Outdated Show resolved Hide resolved

Oddant1 commented

View reviewed changes

qiime2/core/archive/provenance_lib/archive_parser.py Outdated Show resolved Hide resolved

Oddant1 and others added 8 commits

December 18, 2025 18:59


          Update qiime2/core/archive/provenance_lib/archive_parser.py

9c4358d


          Finish docstring

b819605


          Edit docstring

e22b075


          typo

9c0ad91


          Make better use of action_present

6f995ad


          action_present -> _action_present_

29d40c2


          Close alias fh just for a bit of efficiency

2ff09b4


          Merge branch 'prov-lib-refactor' of github.com:Oddant1/qiime2 into pr…

b21065e

…ov-lib-refactor

Oddant1 requested a review from colinvwood

December 19, 2025 20:38

colinvwood reviewed

View reviewed changes

qiime2/core/archive/provenance_lib/tests/test_parse.py Outdated Show resolved Hide resolved

colinvwood approved these changes

View reviewed changes

colinvwood assigned Oddant1 and unassigned colinvwood


          Refactor and remove unused helper

d10d5d2

Oddant1 requested a review from colinvwood

December 22, 2025 23:00

colinvwood approved these changes

View reviewed changes

colinvwood merged commit d2749d8 into rachis-org:dev

4 checks passed

colinvwood moved this from In Review to Changelog Needed in 2026.1 ❄️

colinvwood assigned colinvwood and unassigned Oddant1

colinvwood assigned Oddant1 and unassigned colinvwood

Oddant1 moved this from Changelog Needed to Completed in 2026.1 ❄️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0