Unescape hex/unicode for sample serial data #949
Conversation
sample.html
Outdated
| serialData.data = serialData.data.replace(/\\n/g, "\n").replace(/\\r/g, "\r").replace(/\\t/g, "\t"); | ||
| //allow some escape characters (newlines, tabs, hex/unicode) | ||
| serialData.data = serialData.data.replace(/\\n/g, "\n").replace(/\\r/g, "\r").replace(/\\t/g, "\t") | ||
| .replace(/\\[xu]([\dA-Fa-f]+)/g, (m, s1) => String.fromCharCode(parseInt(s1, 16))); |
There was a problem hiding this comment.
This arrow function breaks IE11 support
There was a problem hiding this comment.
Can this be rewritten like so?
serialData.data = serialData.data.replace(/\\n/g, "\n").replace(/\\r/g, "\r").replace(/\\t/g, "\t")
.replace(/\\[xu]([\dA-Fa-f]+)/g, (m, s1).then(function() {
String.fromCharCode(parseInt(s1, 16))
})
);There was a problem hiding this comment.
yes, but i found a case in retesting where the \x codes can try to collect too many values to convert because of the \u regex combo, so I pushed up a change where the function is a variable to be used for both now split
|
What data should I be testing? I'm kind of arbitrarily sending stuff so not sure if it's valid. Test 1send: Test 2send: |
Those are pretty good tests. Some known hex would be nice (newline, tab, a-z stuff, but in hex format). |
|
I sent hex with new lines and tabs and it seems ok. |
|
For #877