[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a full search if using the default printer (2.1) #935

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Avoid a full search if using the default printer (2.1) #935

merged 1 commit into from
Mar 11, 2022

Conversation

akberenz
Copy link
Member
@akberenz akberenz commented Mar 9, 2022

Fixes #931

@tresf tresf requested a review from klabarge March 9, 2022 03:15
@klabarge
Copy link
Member

This works. When the default printer is used, a full search is skipped.

macOS

[DEBUG] 2022-03-11T13:18:53,795 @ qz.utils.PrintingUtilities:-1
	Using qz.printer.action.PrintPDF to print
[DEBUG] 2022-03-11T13:18:53,796 @ qz.printer.PrintServiceMatcher:-1
	Searching for PrintService matching PDFwriter
[DEBUG] 2022-03-11T13:18:53,858 @ qz.printer.PrintServiceMatcher:-1
	Matched default printer, skipping further search

Windows

[DEBUG] 2022-03-11T13:50:49,790 @ qz.utils.PrintingUtilities:-1
        Using qz.printer.action.PrintPDF to print
[DEBUG] 2022-03-11T13:50:49,791 @ qz.printer.PrintServiceMatcher:-1
        Searching for PrintService matching PDFCreator
[DEBUG] 2022-03-11T13:50:49,792 @ qz.printer.PrintServiceMatcher:-1
        Matched default printer, skipping further search

@tresf tresf merged commit 766b2fc into 2.1 Mar 11, 2022
@tresf tresf deleted the 2.1-quick-default branch March 11, 2022 19:11
@tresf tresf mentioned this pull request Mar 11, 2022
Closed
This was referenced Mar 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tresf tresf tresf approved these changes

@klabarge klabarge klabarge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akberenz @klabarge @tresf