-
-
Notifications
You must be signed in to change notification settings - Fork 139
Fixed Typo in _format.py of line 66 from h264_afm to h264_amf (Sourcery refactored) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ def all(self) -> dict: | |
'c:v': self.video, | ||
'c:a': self.audio, | ||
} | ||
args.update(self.get_codec_options()) | ||
args |= self.get_codec_options() | ||
|
||
return args | ||
|
||
|
@@ -63,7 +63,7 @@ def __init__(self, video: str = "libx264", audio: str = 'aac', **codec_options): | |
""" | ||
@TODO: add documentation | ||
""" | ||
videos = ['libx264', 'h264', 'h264_afm', 'h264_nvenc'] | ||
videos = ['libx264', 'h264', 'h264_amf', 'h264_nvenc'] | ||
audios = ['copy', 'aac', 'libvo_aacenc', 'libfaac', 'libmp3lame', 'libfdk_aac'] | ||
|
||
super(H264, self).__init__(_verify_codecs(video, videos), _verify_codecs(audio, audios), **codec_options) | ||
|
@@ -84,7 +84,7 @@ def get_codec_options(self) -> dict: | |
'sc_threshold': 40 | ||
} | ||
|
||
h264_codec_options.update(self.codec_options) | ||
h264_codec_options |= self.codec_options | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Function
|
||
|
||
return h264_codec_options | ||
|
||
|
@@ -114,7 +114,7 @@ def get_codec_options(self) -> dict: | |
'sc_threshold': 40 | ||
} | ||
|
||
h265_codec_options.update(self.codec_options) | ||
h265_codec_options |= self.codec_options | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Function
|
||
|
||
return h265_codec_options | ||
|
||
|
@@ -140,7 +140,7 @@ def get_codec_options(self) -> dict: | |
""" | ||
vp9_codec_options = {} | ||
|
||
vp9_codec_options.update(self.codec_options) | ||
vp9_codec_options |= self.codec_options | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Function
|
||
|
||
return vp9_codec_options | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function
Format.all
refactored with the following changes:dict-assign-update-to-union
)