Implement the Binary Ninja exporter backend#23
Merged
RobinDavid merged 1 commit intoquarkslab:mainfrom Apr 5, 2025
e2r3p13:binja-exporter
Merged
Implement the Binary Ninja exporter backend#23RobinDavid merged 1 commit intoquarkslab:mainfrom e2r3p13:binja-exporter
RobinDavid merged 1 commit intoquarkslab:mainfrom
e2r3p13:binja-exporter
Conversation
Signed-off-by: lbuckwell <lbuckwell@quarkslab.com>
Collaborator
|
Yes, giving the variable to the export jobs also seem's as a good way to do it. I'll merge and perform few changes once merged. Otherwise looks nice let's merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Binary Ninja exporter backend.
I made sure appropriate backends are used depending on provided command-line arguments, but didn't tested Ghidra and IDA backends on my machine (if you have some time to test them).
Note: On my machine, passing the backend around as a global wasn't working. The
BACKENDvariable wasn't updated even if declared with theglobalkeyword inmain. For this reason, I declared it inmainas a local variable and passed it toexport_jobas a parameter.