8000 "sampler" is currently a keyword argument for QNSPSA by julenl · Pull Request #218 · qiskit-community/qiskit-algorithms · GitHub
[go: up one dir, main page]
Skip to content

"sampler" is currently a keyword argument for QNSPSA #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 31, 2025
Merged

"sampler" is currently a keyword argument for QNSPSA #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5cb7215
"sampler" is currently a keyword argument
julenl Feb 27, 2025
624aa54
Merge pull request #1 from julenl/julenl-patch-1
julenl Mar 4, 2025
98a0acf
Updated the arguments for get_fidelity
julenl Mar 5, 2025
2cd5e7f
Added release note for update on QNSPSA.get_fidelity
julenl Mar 10, 2025
140cdec
Updated release notes according to comments from @woodsp-imb
julenl Mar 10, 2025
7e43bd1
Merge branch 'main' into main
woodsp-ibm Mar 17, 2025
0a90153
Update releasenotes/notes/sampler_as_positional_arg_for_qnspsa-2efca1…
julenl Mar 19, 2025
1363712
Merge branch 'main' into main
woodsp-ibm Mar 19, 2025
406a179
Updated copyright at qnspsa.py
julenl Mar 20, 2025
b33a0a2
Merge branch 'main' into main
woodsp-ibm Mar 26, 2025
32d97f5
Update releasenotes/notes/sampler_as_positional_arg_for_qnspsa-2efca1…
julenl Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions qiskit_algorithms/optimizers/qnspsa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This code is part of a Qiskit project.
#
# (C) Copyright IBM 2021, 2024.
# (C) Copyright IBM 2021, 2025.
#
# This code is licensed under the Apache License, Version 2.0. You may
# obtain a copy of this license in the LICENSE.txt file in the root directory
Expand Down Expand Up @@ -232,8 +232,7 @@ def settings(self) -> dict[str, Any]:
@staticmethod
def get_fidelity(
circuit: QuantumCircuit,
*,
sampler: BaseSampler | None = None,
sampler: BaseSampler,
) -> Callable[[np.ndarray, np.ndarray], float]:
r"""Get a function to compute the fidelity of ``circuit`` with itself.

Expand Down
7 changes: 7 additions & 0 deletions releasenotes/notes/sampler_as_positional_arg_for_qnspsa-2efca170947f3cd7.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
upgrade:
- |
The list of arguments for `QNSPSA.get_fidelity()` has been updated to
remove the keyword enforcement for `sampler` so also allowing it now
as positional. Additionally the `sampler` must be explicitly specified, as a
valid object, as it no longer supports `None` nor defaults to that.
Loading
0