Add reboot option when downloads complete #23525
Open
+90
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a new "Reboot System" option that allows users to automatically reboot the computer when all downloads are complete, similar to the existing shutdown, suspend, and hibernate options. Changes include: - Add ShutdownDialogAction::Reboot enum value - Implement rebootWhenDownloadsComplete() preference methods - Add GUI menu action for reboot option - Implement OS-specific reboot functionality for Windows, macOS, and Linux (via DBus) - Add reboot confirmation dialog - Disable Hibernate option on macOS as it's not supported via Apple Events API Platform support: - Windows: Uses InitiateSystemShutdownW with reboot flag - macOS: Uses kAERestart Apple Event - Linux: Uses systemd logind, ConsoleKit, or HAL DBus interfaces Closes qbittorrent#10774.
Chocobo1
reviewed
Nov 21, 2025
- Add const qualifier to immutable variables - Remove debug logging from action toggle handlers - Use explicit boolean literals instead of expressions - Initialize AEEventID variable with empty braces - Add parentheses for clarity in compound conditions
glassez
reviewed
Nov 22, 2025
Comment on lines
776
to
+779
| bool isShutdown = pref->shutdownWhenDownloadsComplete(); | ||
| bool isSuspend = pref->suspendWhenDownloadsComplete(); | ||
| bool isHibernate = pref->hibernateWhenDownloadsComplete(); | ||
| bool isReboot = pref->rebootWhenDownloadsComplete(); |
Member
There was a problem hiding this comment.
OFFTOPIC:
I wonder why those mutually exclusive things are provided as separate options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a new "Reboot System" option that allows users to automatically reboot the computer when all downloads are complete, similar to the existing shutdown, suspend, and hibernate options.
Changes include:
Platform support:
Closes #10774.