Add alternative connection limits option for seeding torrents #23065
Conversation
|
What immediately caught my eye in the screenshot is the confusing option "Alternative limit for seeding torrent". It looks like it should be a sub-option of "Maximum number of connections per torrent". Otherwise, it should contain the same text, e.g. "Maximum number of connections per seeding torrent". |
|
The option naming was inspired from the screenshot in the linked issue. It is meant to imply that it is a suboption of the option above it (the screenshot doesn't show it, but the checkbox can only be toggled when "Maximum number of connections per torrent" is enabled). I'm thinking it may be better to just make it a separate option though, so that users can set a limit only for seeding torrents. Edit: Also starting to think that the "AltConnections" naming in the code is unclear. "SeedConnections" would be clearer. Will update this later. |
Usually suboptions in qBittorrent look like the following: |
I agree.
👍 |
👎 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Ok, renaming done. Hopefully didn't miss anything (I tried to automate it with sed as best as I could). Also I guess this requires a DB upgrade due to changing an existing option name... see newest commit. Edit: Or alternatively this commit could be dropped and the DB name kept as-is. But then it would be inconsistent with the names in the code. |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
Bump. As far as I can tell, the failed checks are unrelated to the code added here. |
|
I think all reviews so far are covered now. |
This PR adds a new option to the Connection settings: a checkbox + spinbox "Maximum number of connections per seeding torrent" which allows the user to configure a different connection limit for seeding torrents. The rationale for this is laid out in #2193 -- basically it is not necessary to have as many connections when seeding a torrent vs when downloading it. I have not worked on this codebase before, let me know if there is a better way to achieve this.
Resolves #2193.
Edit: Updated screenshot.