Correcting Perf Estimates for TWRW #2782
Closed
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69993523 |
gregmacnamara
added a commit
to gregmacnamara/torchrec
that referenced
this pull request
Mar 6, 2025
Summary: Correcting estimates for A2A. FWD needs adjustment for size of A2A process group. BWD was missing A2A. Also update values for bandwidth and update the expected values for perf related unit tests Differential Revision: D69993523
9a455ea to
fe9f51a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69993523 |
fe9f51a to
d4d0606
Compare
gregmacnamara
added a commit
to gregmacnamara/torchrec
that referenced
this pull request
Mar 6, 2025
Summary: Pull Request resolved: pytorch#2782 Correcting estimates for A2A. FWD needs adjustment for size of A2A process group. BWD was missing A2A. Also update values for bandwidth and update the expected values for perf related unit tests Differential Revision: D69993523
d4d0606 to
66cf24f
Compare
gregmacnamara
added a commit
to gregmacnamara/torchrec
that referenced
this pull request
Mar 11, 2025
Summary: Correcting estimates for TWRW Comms in sharding perf estimators. FWD needs adjustment for size of A2A process group. BWD was missing A2A. Differential Revision: D69993523
66cf24f to
ef30530
Compare
gregmacnamara
added a commit
to gregmacnamara/torchrec
that referenced
this pull request
Mar 11, 2025
Summary: Correcting estimates for TWRW Comms in sharding perf estimators. FWD needs adjustment for size of A2A process group. BWD was missing A2A. Differential Revision: D69993523
|
This pull request was exported from Phabricator. Differential Revision: D69993523 |
Summary: Pull Request resolved: pytorch#2782 Correcting estimates for TWRW Comms in sharding perf estimators. FWD needs adjustment for size of A2A process group. BWD was missing A2A. Differential Revision: D69993523
|
This pull request was exported from Phabricator. Differential Revision: D69993523 |
ef30530 to
200788f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Correcting estimates for A2A. FWD needs adjustment for size of A2A process group. BWD was missing A2A.
Also update values for bandwidth and update the expected values for perf related unit tests
Differential Revision: D69993523