Always run binary upload #4958
Merged
Always run binary upload #4958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This looks good, lets keep 3.8 only for tests. Since this is done to save cost and time to signal. |
atalman
approved these changes
Feb 20, 2024
huydhn
added a commit
that referenced
this pull request
Feb 20, 2024
Using `always()` allows binary upload to run even if some binary builds fails, i.e. text conda 3.12 https://github.com/pytorch/text/actions/runs/7975119767/job/21772574739. The upload job will also fail expectedly because it couldn't find any artifacts on GitHub. However, any working combinations will still be uploaded normally. I also update the test script to test both minimum (3.8) and maximum (3.12) versions. ### Testing https://github.com/pytorch/test-infra/actions/runs/7979242479/job/21786218059?pr=4958 shows that the upload job is run and failed because it couldn't find the artifacts on GH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
always()allows binary upload to run even if some binary builds fails, i.e. text conda 3.12 https://github.com/pytorch/text/actions/runs/7975119767/job/21772574739. The upload job will also fail expectedly because it couldn't find any artifacts on GitHub. However, any working combinations will still be uploaded normally.I also update the test script to test both minimum (3.8) and maximum (3.12) versions.
Testing
https://github.com/pytorch/test-infra/actions/runs/7979242479/job/21786218059?pr=4958 shows that the upload job is run and failed because it couldn't find the artifacts on GH