8000 Move upload step to github after post-script by atalman · Pull Request #4894 · pytorch/test-infra · GitHub
[go: up one dir, main page]
Skip to content

Move upload step to github after post-script #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2024
Merged

Move upload step to github after post-script #4894

merged 2 commits into from
Jan 17, 2024

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Jan 17, 2024 •
edited
Loading

Fixes: pytorch/vision#8219

We need to upload to Github and then do repo after post script is competed. In Case of vision wheels it does wheel relocation.

@vercel Vercel
Copy link
vercel bot commented Jan 17, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2024
huydhn
huydhn approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor
@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's weird to see that build wheels Windows is the one that has the correct sequence :)

@atalman atalman merged commit ba88604 into pytorch:main Jan 17, 2024
huydhn pushed a commit that referenced this pull request Feb 12, 2024
@atalman @huydhn
Move upload step to github after post-script (#4894)
fcbca0d
This was referenced Feb 12, 2024
Merged
Closed
huydhn added a commit that referenced this pull request Feb 12, 2024
@huydhn @atalman
Cherry pick a bunch of OIDC changes for 2.2.1 release (#4945)
c76d973 
The list includes:

* #4870
* #4877
* #4882
* #4886
* #4891
* #4893
* #4894
* #4901

---------

Co-authored-by: Andrey Talman <atalman@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: '_OpNamespace' 'image' object has no attribute 'encode_png' when upgrading to torch==2.3.0.20240116 nightly
3 participants
@atalman @huydhn @facebook-github-bot
0