Disable flaky linalg.det.singular tests on ROCm #96707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96707
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e973766: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
8000
huydhn
force-pushed
the
disable-rocm-test
branch
from
March 14, 2023 01:35
6193f2b to
78e6fb8
Compare
Fixes pytorch#93044
clee2000
approved these changes
Mar 14, 2023
|
@pytorchbot merge |
Merge failedReason: This PR needs a label If not, please add the For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
cc @jaglinux for more context as well as additional tests that we will need to enable once we root cause the failures. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
Related issues: pytorch/pytorch#93044 and pytorch/pytorch#93045. * No access to runner to debug ROCm flakiness * Haven't seen any update on the two issues above * Tests are still flaky whenever they are closed ### Testing The tests are skipped https://ossci-raw-job-status.s3.amazonaws.com/log/11976899251 ``` 2023-03-14T03:39:02.1336514Z test_ops_gradients.py::TestBwdGradientsCUDA::test_fn_grad_linalg_det_singular_cuda_complex128 SKIPPED (Flaky on ROCm pytorch/pytorch#93044) [ 27%] ... 2023-03-14T03:41:46.4234072Z test_ops_fwd_gradients.py::TestFwdGradientsCUDA::test_forward_mode_AD_linalg_det_singular_cuda_complex128 SKIPPED (Flaky on ROCm pytorch/pytorch#93045) [ 44%] ``` Pull Request resolved: pytorch/pytorch#96707 Approved by: https://github.com/clee2000
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
Related issues: pytorch/pytorch#93044 and pytorch/pytorch#93045. * No access to runner to debug ROCm flakiness * Haven't seen any update on the two issues above * Tests are still flaky whenever they are closed ### Testing The tests are skipped https://ossci-raw-job-status.s3.amazonaws.com/log/11976899251 ``` 2023-03-14T03:39:02.1336514Z test_ops_gradients.py::TestBwdGradientsCUDA::test_fn_grad_linalg_det_singular_cuda_complex128 SKIPPED (Flaky on ROCm pytorch/pytorch#93044) [ 27%] ... 2023-03-14T03:41:46.4234072Z test_ops_fwd_gradients.py::TestFwdGradientsCUDA::test_forward_mode_AD_linalg_det_singular_cuda_complex128 SKIPPED (Flaky on ROCm pytorch/pytorch#93045) [ 44%] ``` Pull Request resolved: pytorch/pytorch#96707 Approved by: https://github.com/clee2000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #93044 and #93045.
Testing
The tests are skipped https://ossci-raw-job-status.s3.amazonaws.com/log/11976899251
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport