8000 [inductor] weight prepack for single conv_transpose2d by chunyuan-w · Pull Request #90267 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[inductor] weight prepack for single conv_transpose2d #90267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[inductor] weight prepack for single conv_transpose2d #90267

wants to merge 19 commits into from
+23 −3

Conversation

chunyuan-w
Copy link
Collaborator
@chunyuan-w chunyuan-w commented Dec 6, 2022 •
edited
Loading

@pytorch-bot
Copy link
pytorch-bot bot commented Dec 6, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90267

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 Failures

As of commit 4aaceb8:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Dec 6, 2022
Closed
Closed
Closed
@chunyuan-w chunyuan-w marked this pull request as draft December 6, 2022 07:35
@chunyuan-w chunyuan-w added the topic: not user facing topic category label Dec 6, 2022
chunyuan-w added a commit that referenced this pull request Dec 6, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
3e68f40 
ghstack-source-id: 3e4a0b7
Pull Request resolved: #90267
chunyuan-w added a commit that referenced this pull request Dec 6, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
3c5d149 
ghstack-source-id: e1a7c2f
Pull Request resolved: #90267
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
3a29578 
[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
99105b1 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
d679491 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
f538f39 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Dec 8, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
f497680 
ghstack-source-id: 0bc4a5a
Pull Request resolved: #90267
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
0eb04ad 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
a87281c 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Dec 9, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
9bc141e 
ghstack-source-id: 8244140
Pull Request resolved: #90267
jgong5
jgong5 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator
@jgong5 jgong5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torch/_inductor/overrides.py
Comment on lines 1355 to 1359
computation_op_packed_map = {
nn.Linear: packed_linear_eval,
nn.Conv2d: packed_conv_eval,
nn.ConvTranspose2d: packed_conv_transpose_eval,
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR but shall we introduce a configurable option (default to false) to disable weight prepacking? Just in case there is issue about weight prepacking that we want to triage with it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#93811 implements this feature.

chunyuan-w added a commit that referenced this pull request Dec 9, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
59ce80d 
ghstack-source-id: c0b94f3
Pull Request resolved: #90267
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
524d104 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
e4cc74b 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Dec 15, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
33ab9ce 
ghstack-source-id: bec94bb
Pull Request resolved: #90267
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
2ff10ad 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Dec 15, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
2befe0d 
ghstack-source-id: 35bf772
Pull Request resolved: #90267
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
c8f4900 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
b08af7d 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w chunyuan-w added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 15, 2022
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
cf109a3 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
eb90018 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Dec 19, 2022
@chunyuan-w
[inductor] weight prepack for single conv_transpose2d
8856594 
ghstack-source-id: 35bf772
Pull Request resolved: #90267
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
bea5039 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "[inductor] weight prepack for single conv_transpose2d"
4aaceb8 
This PR enables weight prepack for single conv_transpose2d OP.


cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w chunyuan-w mentioned this pull request Jan 10, 2023
Closed
@chunyuan-w
Copy link
Collaborator Author

Re-opened in #91956

@chunyuan-w chunyuan-w closed this Jan 11, 2023
@EikanWang EikanWang mentioned this pull request Jan 13, 2023
Closed
chunyuan-w added a commit that referenced this pull request Jan 18, 2023
@chunyuan-w
Update base for Update on "[Re-open 90267] [inductor] weight prepack …
443da3b 
…for single conv_transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Jan 18, 2023
@chunyuan-w
Update on "[Re-open 90267] [inductor] weight prepack for single conv_…
06b0cf6 
…transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Jan 31, 2023
@chunyuan-w
Update base for Update on "[Re-open 90267] [inductor] weight prepack …
5f7fc90 
…for single conv_transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Jan 31, 2023
@chunyuan-w
Update on "[Re-open 90267] [inductor] weight prepack for single conv_…
795a8a4 
…transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Jan 31, 2023
@chunyuan-w
Update base for Update on "[Re-open 90267] [inductor] weight prepack …
3dcb4e8 
…for single conv_transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Jan 31, 2023
@chunyuan-w
Update on "[Re-open 90267] [inductor] weight prepack for single conv_…
eabf3bb 
…transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Jan 31, 2023
@chunyuan-w
Update base for Update on "[Re-open 90267] [inductor] weight prepack …
0a9ca73 
…for single conv_transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Jan 31, 2023
@chunyuan-w
Update on "[Re-open 90267] [inductor] weight prepack for single conv_…
7f885ec 
…transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Feb 1, 2023
@chunyuan-w
Update base for Update on "[Re-open 90267] [inductor] weight prepack …
84ceadb 
…for single conv_transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Feb 1, 2023
@chunyuan-w
Update on "[Re-open 90267] [inductor] weight prepack for single conv_…
59a1d45 
…transpose2d"


Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Feb 1, 2023
@chunyuan-w @pytorchmergebot
[Re-open 90267] [inductor] weight prepack for single conv_transpose2d (…
f1030dc 
…#91956)

Re-open #90267 since earlier pr on that stack got reverted.
Depend on internal ideep upgrade.
[Update]: internal ideep upgrade issue is resolved in #92239.

Pull Request resolved: #91956
Approved by: https://github.com/jgong5, https://github.com/desertfire
@facebook-github-bot facebook-github-bot deleted the gh/chunyuan-w/18/head branch June 8, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

@jgong5 jgong5 jgong5 approved these changes

@XiaobingSuper XiaobingSuper Awaiting requested review from XiaobingSuper

@EikanWang EikanWang Awaiting requested review from EikanWang

@desertfire desertfire Awaiting requested review from desertfire

@Chillee Chillee Awaiting requested review from Chillee

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: inductor open source topic: not user facing topic category
Projects
PyTorch Intel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chunyuan-w @jansel @jgong5 @pytorchbot
0