8000 [MPS] Add binary operations dtype precedence test case by lhoenig · Pull Request #87545 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[MPS] Add binary operations dtype precedence test case #87545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Add binary operations dtype precedence test case #87545

wants to merge 2 commits into from

Conversation

lhoenig
Copy link
Contributor
@lhoenig lhoenig commented Oct 22, 2022

See #84742 and #78319.

The test case tests that

  • for the binary operations (add, sub, mul, div),
  • for all data types (dtypes),
  • for a range of representative values and their combinations,
  • for various shapes and ways of creating the test tensors,

the contents and dtype of the result tensor is identical for the MPS and CPU backends.

It adds about 15-18s runtime to test_mps.py.

@lhoenig lhoenig requested a review from kulinseth as a code owner October 22, 2022 09:05
8000
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) topic: not user facing topic category labels Oct 22, 2022
@pytorch-bot
Copy link
pytorch-bot bot commented Oct 22, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87545

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a846843:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@lhoenig lhoenig mentioned this pull request Oct 22, 2022
Closed
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 23, 2022
@kit1980
Copy link
Contributor
kit1980 commented Nov 16, 2022

LGTM! @lhoenig, can you resolve the conflict?

@lhoenig
Copy link
Contributor Author
lhoenig commented Nov 16, 2022

Thanks @kit1980! Conflict resolved.

@kit1980
Copy link
Contributor
kit1980 commented Nov 17, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 17, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lhoenig @kit1980 @pytorchmergebot @ngimel @pytorchbot
0