8000 Reenable aot tests on windows for cuda 11.7 and up by atalman · Pull Request #87193 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Reenable aot tests on windows for cuda 11.7 and up #87193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Oct 18, 2022

Reenable aot tests on windows for cuda 11.7 and up

Issue: #69460 seems to be mitigated in CUDA 11.7 hence re-enable this test

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm

@atalman atalman requested a review from a team as a code owner October 18, 2022 13:04
@pytorch-bot
Copy link
pytorch-bot bot commented Oct 18, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87193

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 1 Pending

As of commit 258a24e:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 18, 2022
@atalman atalman changed the title Reenable aot tests on windows Reenable aot tests on windows for cuda 11.7 and up Oct 18, 2022
@atalman atalman added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR module: windows Windows support for PyTorch labels Oct 18, 2022
@malfet
Copy link
Contributor
malfet commented Oct 18, 2022

Your base commit is from Feb 16th, not sure if one can collect any signal on 11.7 using such an old PR base:
image

@atalman atalman force-pushed the enable_aot_test_windows branch from e7dff6d to e43787a Compare October 18, 2022 14:31
@atalman atalman requested a review from malfet October 18, 2022 14:32
@atalman atalman force-pushed the enable_aot_test_windows branch from 7edb5ae to 729f97e Compare October 18, 2022 19:48
@atalman atalman force-pushed the enable_aot_test_windows branch from 729f97e to 258a24e Compare October 18, 2022 20:48
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2022
@atalman
Copy link
Contributor Author
atalman commented Oct 19, 2022

@pytorchmergebot merge -f "linux-bionic-cuda11.7-py3.10-gcc7 failure is expected"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman added a commit to atalman/pytorch that referenced this pull request Oct 19, 2022
Reenable aot tests on windows for cuda 11.7 and up

Issue: pytorch#69460 seems to be mitigated in CUDA 11.7 hence re-enable this test

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm
Pull Request resolved: pytorch#87193
Approved by: https://github.com/malfet
malfet pushed a commit that referenced this pull request Oct 20, 2022
Reenable aot tests on windows for cuda 11.7 and up

Issue: #69460 seems to be mitigated in CUDA 11.7 hence re-enable this test

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm
Pull Request resolved: #87193
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: windows Windows support for PyTorch topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0