10000 Try reenable the aot tests by atalman · Pull Request #85966 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Try reenable the aot tests #85966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Try reenable the aot tests #85966

wants to merge 3 commits into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Sep 30, 2022

Fixes #ISSUE_NUMBER

@atalman atalman requested a review from a team as a code owner September 30, 2022 13:52
@pytorch-bot
Copy link
pytorch-bot bot commented Sep 30, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85966

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures, 1 Pending

As of commit 7329e27:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 30, 2022
@atalman atalman added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR module: windows Windows support for PyTorch labels Sep 30, 2022
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@atalman atalman force-pushed the test_windows_etension branch from 9757894 to 7329e27 Compare October 13, 2022 18:49
malfet
malfet requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate formatting and functional changes.
I have no idea what line or two one is expected to review in 400+ lines formatting diff)

@atalman atalman marked this pull request as draft October 13, 2022 19:24
@atalman
Copy link
Contributor Author
atalman commented Oct 13, 2022

Please separate formatting and functional changes. I have no idea what line or two one is expected to review in 400+ lines formatting diff)

sorry about this. not intend to ship this. Just a test see if we are getting the same error

@atalman atalman mentioned this pull request Oct 14, 2022
Closed
@atalman atalman closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet requested changes

Assignees
No one assigned
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR cla signed module: windows Windows support for PyTorch topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @facebook-github-bot @malfet
0