8000 Back out "[const_fold] Set requires_grad based on the folded tensor; add device_for_folding option" by singlaiiit · Pull Request #79655 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Back out "[const_fold] Set requires_grad based on the folded tensor; add device_for_folding option" #79655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Back out "[const_fold] Set requires_grad based on the folded tensor; add device_for_folding option" #79655

wants to merge 1 commit into from

Conversation

singlaiiit
Copy link
Contributor

Reviewed By: yinghai, khabinov

Differential Revision: D37192230

@singlaiiit @facebook-github-bot
Back out "[const_fold] Set requires_grad based on the folded tensor; …
4448449 
…add device_for_folding option"

Reviewed By: yinghai, khabinov

Differential Revision: D37192230

fbshipit-source-id: 851d0e8a2e0799efb402a23c5d751ab5c2aee77b
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 15, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 4448449 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37192230

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @singlaiiit.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
< 8000 div class="d-flex flex-md-row flex-column">
@singlaiiit @facebook-github-bot
Back out "[const_fold] Set requires_grad based on the folded tensor; …
b8dcd6a 
…add device_for_folding option" (#79655)

Summary: Pull Request resolved: #79655

Reviewed By: yinghai, khabinov

Differential Revision: D37192230

fbshipit-source-id: 4ae1863e28ff30c23795c4a7a79461dd76484143
@facebook-github-bot
Copy link
Contributor

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here

pytorchmergebot added a commit that referenced this pull request Jun 17, 2022
@pytorchmergebot
Revert "Back out "[const_fold] Set requires_grad based on the folded …
e627dd5 
…tensor; add device_for_folding option" (#79655)"

This reverts commit 24c2aff.

Reverted #79655 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by d4bbebb. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

@zengk95 zengk95 mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinghai yinghai yinghai approved these changes

@khabinov khabinov khabinov approved these changes

Assignees
No one assigned
Labels
cla signed fb-exported Merged module: fx Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@singlaiiit @facebook-github-bot @pytorchmergebot @yinghai @khabinov
0