8000 [ONNX] Enable test_fill script test by shubhambhokare1 · Pull Request #79555 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ONNX] Enable test_fill script test #79555

New issue
< 10000 div class="mt-3 mb-2 text-center">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[ONNX] Enable test_fill script test #79555

wants to merge 4 commits into from

Conversation

shubhambhokare1
Copy link
Collaborator

For scripting mode, aten::clone requires input to be a TensorType. Hence if we encounter an IntType, FloatType or BoolType input, we set the input to the appropriate TensorType

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 14, 2022 •
edited
Loading

🔗 Helpful links

❌ 2 New Failures

As of commit 4afda84ed8 (more details on the Dr. CI page):

Expand to see more
  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-py3.7-clang9 / test (default, 2, 2, linux.2xlarge) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-07-07T23:18:06.7829721Z RuntimeError: test_cpp_extensions_aot_no_ninja failed! 
2022-07-07T23:18:06.2101003Z cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
2022-07-07T23:18:06.2110836Z g++ -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -pthread -shared -B /opt/conda/compiler_compat -L/opt/conda/lib -Wl,-rpath=/opt/conda/lib -Wl,--no-as-needed -Wl,--sysroot=/ build/temp.linux-x86_64-3.7/extension.o -L/opt/conda/lib/python3.7/site-packages/torch/lib -lc10 -ltorch -ltorch_cpu -ltorch_python -o build/lib.linux-x86_64-3.7/torch_test_cpp_extension/cpp.cpython-37m-x86_64-linux-gnu.so
2022-07-07T23:18:06.4833961Z building 'torch_test_cpp_extension.ort' extension
2022-07-07T23:18:06.4836263Z gcc -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -Iself_compiler_include_dirs_test -I/opt/conda/include/python3.7m -c ort_extension.cpp -o build/temp.linux-x86_64-3.7/ort_extension.o -g -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_clang\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1002\" -DTORCH_EXTENSION_NAME=ort -D_GLIBCXX_USE_CXX11_ABI=1 -std=c++14
2022-07-07T23:18:06.5680546Z error: command '/opt/cache/bin/gcc' failed with exit code -7
2022-07-07T23:18:06.7824031Z Traceback (most recent call last):
2022-07-07T23:18:06.7824454Z   File "test/run_test.py", line 945, in <module>
2022-07-07T23:18:06.7825870Z     main()
2022-07-07T23:18:06.7826216Z   File "test/run_test.py", line 923, in main
2022-07-07T23:18:06.7829286Z     raise RuntimeError(err_message)
2022-07-07T23:18:06.7829721Z RuntimeError: test_cpp_extensions_aot_no_ninja failed!
2022-07-07T23:18:07.0492933Z 
2022-07-07T23:18:07.0493447Z real	39m43.903s
2022-07-07T23:18:07.0493652Z user	91m58.027s
2022-07-07T23:18:07.0493825Z sys	5m13.498s
2022-07-07T23:18:07.0531835Z ##[error]Process completed with exit code 1.
2022-07-07T23:18:07.0575947Z Prepare all required actions
2022-07-07T23:18:07.0576234Z Getting action download info
2022-07-07T23:18:07.2312078Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-07-07T23:18:07.2312298Z with:
2022-07-07T23:18:07.2312613Z   github-token: ***

See GitHub Actions build pull / linux-focal-py3.7-clang10-onnx / test (default, 2, 2, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-07-07T22:56:52.9658004Z RuntimeError: Unsupported prim::Constant kind: `f`. Send a bug report. 
2022-07-07T22:56:52.9654550Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/utils.py", line 1421, in _export
2022-07-07T22:56:52.9654827Z     dynamic_axes=dynamic_axes,
2022-07-07T22:56:52.9655200Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/utils.py", line 1062, in _model_to_graph
2022-07-07T22:56:52.9655464Z     module=module,
2022-07-07T22:56:52.9655806Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/utils.py", line 624, in _optimize_graph
2022-07-07T22:56:52.9656127Z     graph = _C._jit_pass_onnx(graph, operator_export_type)
2022-07-07T22:56:52.9656546Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/utils.py", line 1739, in _run_symbolic_function
2022-07-07T22:56:52.9656848Z     return symbolic_fn(ctx, g, *inputs, **attrs)
2022-07-07T22:56:52.9657242Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/symbolic_opset9.py", line 5561, in Constant
2022-07-07T22:56:52.9657679Z     f"Unsupported prim::Constant kind: `{n.kindOf('value')}`. Send a bug report."
2022-07-07T22:56:52.9658004Z RuntimeError: Unsupported prim::Constant kind: `f`. Send a bug report.
2022-07-07T22:56:53.0471854Z �[33m=============================== warnings summary ===============================�[0m
2022-07-07T22:56:53.0474120Z ../.local/lib/python3.7/site-packages/torchvision/transforms/functional_pil.py:207
2022-07-07T22:56:53.0474921Z ../.local/lib/python3.7/site-packages/torchvision/transforms/functional_pil.py:207
2022-07-07T22:56:53.0475512Z ../.local/lib/python3.7/site-packages/torchvision/transforms/functional_pil.py:207
2022-07-07T22:56:53.0475925Z ../.local/lib/python3.7/site-packages/torchvision/transforms/functional_pil.py:207
2022-07-07T22:56:53.0476742Z   /var/lib/jenkins/.local/lib/python3.7/site-packages/torchvision/transforms/functional_pil.py:207: DeprecationWarning: BILINEAR is deprecated and will be removed in Pillow 10 (2023-07-01). Use Resampling.BILINEAR instead.
2022-07-07T22:56:53.0477549Z     def resize(img, size, interpolation=Image.BILINEAR):
2022-07-07T22:56:53.0477852Z 
2022-07-07T22:56:53.0478101Z ../.local/lib/python3.7/site-packages/torchvision/transforms/functional_pil.py:280
2022-07-07T22:56:53.0478522Z ../.local/lib/python3.7/site-packages/torchvision/transforms/functional_pil.py:280
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 14, 2022
@justinchuby justinchuby added the module: onnx Related to torch.onnx label Jun 16, 2022
@justinchuby justinchuby self-assigned this Jun 16, 2022
@justinchuby justinchuby changed the title [ONNX]Enable test_fill script test [ONNX] Enable test_fill script test Jun 16, 2022
@justinchuby
Copy link
Collaborator

lgtm. @BowenBao Could you help talk a look too?

BowenBao
BowenBao approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator
@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shubhambhokare1 shubhambhokare1 mentioned this pull request Jul 14, 2022
Open
15 tasks
@shubhambhokare1 shubhambhokare1 linked an issue Jul 14, 2022 that may be closed by this pull request
[ONNX] Support unit tests in scripting that we already support in tracing #75625
Open
15 tasks
@BowenBao
Copy link
Collaborator

@shubhambhokare1 do we still need this? If so please update and merge :)

@justinchuby justinchuby mentioned this pull request Sep 25, 2022
Closed
28 tasks
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link
linux-foundation-easycla bot commented Oct 3, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot
Copy link
pytorch-bot bot commented Oct 17, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/79555

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 688460c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2022
@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/fill_script branch 3 times, most recently from 6448d2e to 373b945 Compare October 19, 2022 20:33
@shubhambhokare1
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64-mps / Run MPS tests

Details for Dev Infra team Raised by workflow job

@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/fill_script branch 2 times, most recently from 993958f to eb1a584 Compare October 20, 2022 18:33
@shubhambhokare1
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @shubhambhokare1.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@shubhambhokare1 @kulinseth
[ONNX] Enable test_fill script test (pytorch#79555)
3509629 
For scripting mode, aten::clone requires input to be a TensorType. Hence if we encounter an IntType, FloatType or BoolType input, we set the input to the appropriate TensorType
Pull Request resolved: pytorch#79555
Approved by: https://github.com/justinchuby, https://github.com/BowenBao, https://github.com/abock
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@shubhambhokare1 @kulinseth
[ONNX] Enable test_fill script test (pytorch#79555)
4d19d5a 
For scripting mode, aten::clone requires input to be a TensorType. Hence if we encounter an IntType, FloatType or BoolType input, we set the input to the appropriate TensorType
Pull Request resolved: pytorch#79555
Approved by: https://github.com/justinchuby, https://github.com/BowenBao, https://github.com/abock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagocrepaldi thiagocrepaldi thiagocrepaldi left review comments

@justinchuby justinchuby justinchuby approved these changes

@abock abock abock approved these changes

@BowenBao BowenBao BowenBao approved these changes

Assignees

@justinchuby justinchuby

Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: onnx Related to torch.onnx oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ONNX] Support unit tests in scripting that we already support in tracing
8 participants
@shubhambhokare1 @facebook-github-bot @justinchuby @BowenBao @pytorchmergebot @abock @thiagocrepaldi @pytorchbot
0