10000 ENH: Add a force argument to `numpy()` by HaoZeke · Pull Request #78564 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add a force argument to numpy() #78564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

ENH: Add a force argument to numpy() #78564

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e2bf93f
addition of basic test for Tensor.numpy(force = True)
martinPasen Jun 8, 2021
da00113
implemented argument force in Tensor.numpy()
martinPasen Jun 10, 2021
e438e96
adding test for sparse tensors
martinPasen Jun 10, 2021
390f2d2
modified .numpy() to always throw error, if tensor is sparse (even if…
martinPasen Jun 17, 2021
4937857
updated tests about sparse tensors and extend tests to cover conj()
martinPasen Jun 17, 2021
737a6ac
documentation
martinPasen Jun 21, 2021
d9ee027
makeing force kwarg only argument
martinPasen Jun 21, 2021
f30497f
cleaning of code
martinPasen Jun 21, 2021
1ada0c9
minor documentation fixes and deleting redundant ternary operator
martinPasen Jun 23, 2021
e4f17ee
nit docs update
martinPasen Jun 23, 2021
a7eed4f
documentation typo
martinPasen Jun 23, 2021
5905324
unified error messages in tensor.numpy(), fixing test, making tests m…
martinPasen Jun 26, 2021
c5b51ae
documentation refactor
martinPasen Jun 26, 2021
a472c3c
fixed failing test(reason was changed error message)
martinPasen Jul 2, 2021
56a2688
undelet of deletion
martinPasen Jul 2, 2021
682fbdf
DOC: Minor cleanup to include negative resolution
HaoZeke May 29, 2022
887562a
BUG: Fix idiotic typo
HaoZeke May 29, 2022
41c0d18
TST: Rework docstrings to pass regex assertions
HaoZeke May 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unified error messages in tensor.numpy(), fixing test, making tests m… 
…ore specific with assertRaisesRegex
  • Loading branch information
@martinPasen @HaoZeke
martinPasen authored and HaoZeke committed May 29, 2022
commit 5905324b962fbd09085b4c37ac6dcd349cb7eeeb
5 changes: 3 additions & 2 deletions test/test_numpy_interop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,10 @@ def test_to_numpy_force_argument(self, device) -> None:
y = x.resolve_conj()
expect_error = requires_grad or sparse or conj or not device == 'cpu'
if not force and expect_error:
self.assertRaises((RuntimeError, TypeError), lambda: x.numpy())
self.assertRaisesRegex((RuntimeError, TypeError), "Use tensor\..*\.numpy\(\) instead\.", lambda: x.numpy())
self.assertRaisesRegex((RuntimeError, TypeError), "Use tensor\..*\.numpy\(\) instead\.", lambda: x.numpy(force=False))
elif force and sparse:
self.assertRaises(TypeError, lambda: x.numpy())
self.assertRaisesRegex(TypeError, "Use tensor\..*\.numpy\(\) instead\.", lambda: x.numpy(force=True))
else:
self.assertEqual(x.numpy(force=force), y)

Expand Down
0