8000 MPS: Datatype precedence in binary ops [WIP] by lhoenig · Pull Request #78319 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

MPS: Datatype precedence in binary ops [WIP] #78319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

MPS: Datatype precedence in binary ops [WIP] #78319

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
174e34e
Implement dtype precedence in binaryOpTensor
lhoenig May 25, 2022
152a797
Merge branch 'master' into mps-binops-dtype-precedence
lhoenig May 25, 2022
9debeaf
Add test_binops_dtype_precedence and todo notes
lhoenig May 25, 2022
c84c93d
Attempt to fix torch.full on MPS for bool values, more problem descri…
lhoenig May 26, 2022
8c5114d
improve comment
lhoenig May 26, 2022
7253344
add todo
lhoenig May 26, 2022
e80ef13
elaborate comment
lhoenig May 26, 2022
f71a4a8
improve comment
lhoenig May 26, 2022
dc1c302
Merge branch 'master' into mps-binops-dtype-precedence
lhoenig May 28, 2022
ec475d3
Fix division on MPS
lhoenig May 28, 2022
b2073e4
Update test
lhoenig May 28, 2022
64d9b18
update test
lhoenig May 28, 2022
f86d924
update comments with new information
lhoenig May 28, 2022
8592fa9
Merge branch 'master' into mps-binops-dtype-precedence
< 8000 span class="description"> lhoenig May 30, 2022
c10d75b
re-add import that somehow got removed by merge
lhoenig May 30, 2022
2990b48
fix merge
lhoenig May 30, 2022
2451c33
Merge branch 'master' into mps-binops-dtype-precedence
lhoenig Jun 4, 2022
c3f3e38
remove double test
lhoenig Jun 4, 2022
dc0bc93
remove trailing whitespace
lhoenig Jun 4, 2022
4db40e8
remove unused import
lhoenig Jun 4, 2022
674b933
Merge branch 'master' into mps-binops-dtype-precedence
lhoenig Sep 27, 2022
d028f9e
Update submodules
lhoenig Sep 27, 2022
b9d1d71
Merge
lhoenig Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comments with new information
  • Loading branch information
@lhoenig
lhoenig committed May 28, 2022
commit f86d924aaa38df7159dcb08153d160e636961d83
3 changes: 2 additions & 1 deletion test/test_mps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,7 @@ def test_binops_dtype_precedence(self):
torch.int16: [-15, 0, 1, 10],
torch.int32: [-376, 0, 1, 13],
torch.int64: [-8, 0, 1, 77],
# torch.float16: [-234.5, 0.0, 1.0, 2.0], # TODO: Broken, currently unknown why
# torch.float16: [-234.5, 0.0, 1.0, 2.0], # TODO: Only add/sub work correctly, currently unknown why
torch.float32: [-1.0, 0.0, 0.1, 111.99],
}
# Test all combinations of dtypes, operations, dimensionality
Expand Down Expand Up @@ -1353,6 +1353,7 @@ def test_binops_dtype_precedence(self):
# Multiple problems with [MPSGraph constantWithScalar:shape:dataType:] prevent
# these tests from completing successfully currently
# TODO: Research problem with int16, is it also related to constantWithScalar?
# - Likely, getting result tensor with 5/10 correct entries
# TODO: Stateful bug with False, False, add in assert5? Related to the cache key
# or more serious problem?
# - Cache key looks correct, behavior currently completely unexplained
Expand Down
0