8000 masked logsumexp/logaddexp by george-qi · Pull Request #77876 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

masked logsumexp/logaddexp #77876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

masked logsumexp/logaddexp #77876

wants to merge 14 commits into from

Conversation

george-qi
Copy link
Contributor
@george-qi george-qi commented May 19, 2022 •
edited
Loading

@george-qi
masked logasumexp/logaddexp
b482cd0 
[ghstack-poisoned]
@george-qi george-qi requested review from mruberry and ngimel as code owners May 19, 2022 19:13
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 19, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 8aa8e4f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@george-qi george-qi added the ciflow/trunk Trigger trunk jobs on your pull request label May 19, 2022
george-qi added a commit that referenced this pull request May 19, 2022
@george-qi
masked logsumexp/logaddexp
0572663 
ghstack-source-id: 0678a63
Pull Request resolved: #77876
@george-qi george-qi changed the title masked logasumexp/logaddexp masked logsumexp/logaddexp May 19, 2022
george-qi added a commit that referenced this pull request May 20, 2022
@george-qi
masked logsumexp/logaddexp
e3f20a9 
ghstack-source-id: 32a8398
Pull Request resolved: #77876
@vadimkantorov vadimkantorov mentioned this pull request May 20, 2022
Open
george-qi added a commit that referenced this pull request May 20, 2022
@george-qi
masked logsumexp/logaddexp
79ed298 
ghstack-source-id: fad0cc7
Pull Request resolved: #77876
@george-qi george-qi added module: sparse Related to torch.sparse release notes: sparse release notes category labels May 20, 2022
george-qi added a commit that referenced this pull request May 23, 2022
@george-qi
masked logsumexp/logaddexp
17faa11 
ghstack-source-id: 47499dc
Pull Request resolved: #77876
george-qi added a commit that referenced this pull request May 23, 2022
@george-qi
masked logsumexp/logaddexp
db263d3 
ghstack-source-id: 931d1eb
Pull Request resolved: #77876
@george-qi
Copy link
Contributor Author

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @george-qi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@suo
Copy link
Member
suo commented May 24, 2022

@pytorchbot revert -m "This broke master by adding a weird file, you attempted to delete it by committing on top of the head branch but that's not how ghstack works" -c weird

pytorchmergebot added a commit that referenced this pull request May 24, 2022
@pytorchmergebot
Revert "masked logsumexp/logaddexp"
ee4034e 
This reverts commit 49e15b5.

Reverted #77876 on behalf of https://github.com/suo due to This broke master by adding a weird file, you attempted to delete it by committing on top of the head branch but that's not how ghstack works
@george-qi
Copy link
Contributor Author
george-qi commented May 25, 2022 •
edited
Loading

@pytorchbot revert -m "This broke master by adding a weird file, you attempted to delete it by committing on top of the head branch but that's not how ghstack works" -c weird

indeed weird, not sure how that file got there tbh (hence trying to delete it), i'll just create a new PR..

@george-qi george-qi mentioned this pull request May 25, 2022
Closed
george-qi added a commit that referenced this pull request May 25, 2022
@george-qi
Update on "masked logsumexp/logaddexp"
9bdec9b 
The previous diff was reverted for a weird reason (see #77876), so this is a diff pushing the two ops again

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot deleted the gh/george-qi/40/head branch May 28, 2022 14:17
george-qi added a commit that referenced this pull request Jun 10, 2022
@george-qi
Update base for Update on "masked logsumexp/logaddexp"
9ab938d 
The previous diff was reverted for a weird reason (see #77876), so this is a diff pushing the two ops again

[ghstack-poisoned]
george-qi added a commit that referenced this pull request Jun 10, 2022
@george-qi
Update on "masked logsumexp/logaddexp"
4962303 
The previous diff was reverted for a weird reason (see #77876), so this is a diff pushing the two ops again

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: sparse Related to torch.sparse release notes: sparse release notes category Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@george-qi @facebook-github-bot @suo @cpuhrsch @pytorchmergebot
0