8000 [jiterator] logical_and: complex by khushi-411 · Pull Request #74863 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[jiterator] logical_and: complex #74863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[jiterator] logical_and: complex #74863

wants to merge 14 commits into from

Conversation

khushi-411
Copy link
Contributor
@khushi-411 khushi-411 commented Mar 28, 2022 •
edited
Loading

Hi!
The PR follows: #74748

cc: @kshitij12345! :)

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Mar 28, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 75697cf (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@khushi-411 khushi-411 marked this pull request as draft March 28, 2022 20:42
@khushi-411 khushi-411 marked this pull request as ready for review March 30, 2022 04:06
@kshitij12345
Copy link
Collaborator
kshitij12345 commented Mar 30, 2022 •
edited
Loading

Failure looks real:

======================================================================

FAIL [0.281s]: test_dtypes_logical_and_cuda (__main__.TestCommonCUDA)
----------------------------------------------------------------------

Looks like JITERATOR code fails to compile due to && operator not being available for std::complex (you might have to add it, see #74161)
Code Failure Ref in CI Log : https://github.com/pytorch/pytorch/runs/5748298918?check_suite_focus=true#step:9:13490

@khushi-411
Copy link
Contributor Author

Got that! It looks interesting.
I'll update it soon. Thanks, @kshitij12345! :)

kshitij12345
kshitij12345 reviewed Apr 1, 2022
View reviewed changes
@mruberry mruberry requested a review from anjali411 April 4, 2022 00:21
@mruberry mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 4, 2022
kshitij12345
kshitij12345 reviewed Apr 5, 2022
View reviewed changes
@khushi-411
Copy link
Contributor Author

Hi, @kshitij12345! Hi, @anjali411!
The CI turned green. Gentle ping to you both :)

@khushi-411
Copy link
Contributor Author
khushi-411 commented Apr 13, 2022 •
edited
Loading

Hi @kshitij12345, Hi, @anjali411! :)
Gentle ping!

anjali411
anjali411 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor
@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. will wait for @kshitij12345 to take a final look

@khushi-411 khushi-411 requested a review from kshitij12345 April 15, 2022 06:00
kshitij12345
kshitij12345 approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator
@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @khushi-411

cc: @anjali411

@anjali411
Copy link
Contributor

@pytorchbot merge this please

@github-actions
Copy link
Contributor

Hey @khushi-411.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@khushi-411 khushi-411 deleted the jiterator/logical branch April 16, 2022 08:11
facebook-github-bot pushed a commit that referenced this pull request Apr 18, 2022
@khushi-411 @facebook-github-bot
[jiterator] logical_and: complex (#74863)
23f0222 
Summary:
Hi!
The PR follows: #74748

GitHub CC:
kshitij12345! :)

Pull Request resolved: #74863
Approved by: https://github.com/anjali411, https://github.com/kshitij12345

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fa2c7e2ede1a7313feb489e64b1806fef7a3c232

Reviewed By: mehtanirav

Differential Revision: D35721637

fbshipit-source-id: 62ef35bb84a2e6521b3171bbd9d3121c0236ca0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshitij12345 kshitij12345 kshitij12345 approved these changes

@anjali411 anjali411 anjali411 approved these changes

Assignees
No one assigned
Labels
cla signed open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khushi-411 @facebook-github-bot @kshitij12345 @anjali411 @pytorchbot @mruberry
0