[DataPipe] adding a finally statement to ensure hook is reset #70214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5e24a2d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Dec 20, 2021
NivekT
commented
Dec 21, 2021
| # TODO(VitalyFedyunin): Better do it as `with` context for safety | ||
| IterDataPipe.set_reduce_ex_hook(reduce_hook) | ||
| if exclude_primitive: | ||
| IterDataPipe.set_getstate_hook(getstate_hook) | ||
| try: |
There was a problem hiding this comment.
@ejguan @VitalyFedyunin
I am under the impression that using try ... finally ... here will provide more safety. The reduce and getstate hooks will be re-set to None even if an exception is thrown.
Does that seem better? Or do we have to use a with statement?
ejguan
approved these changes
Dec 21, 2021
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…set" cc @VitalyFedyunin ejguan @NivekT Differential Revision: [D33255306](https://our.internmc.facebook.com/intern/diff/D33255306) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
cc @VitalyFedyunin @ejguan @NivekT
Differential Revision: D33255306