Adding windows cuda 11.5 workflows #69377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit cdd2df9 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
0bb3bb8 to
9e5d4a9
Compare
janeyx99
reviewed
Dec 13, 2021
| @@ -909,6 +910,11 @@ def get_selected_tests(options): | |||
| WINDOWS_BLOCKLIST.append("jit") | |||
| WINDOWS_BLOCKLIST.append("jit_fuser") | |||
|
|
|||
| if distutils.version.LooseVersion(torch.version.cuda) >= "11.5": | |||
There was a problem hiding this comment.
Is there an issue tracking why this is the case? Could you add a comment above here explaining why this has to be/linking to the issue?
There was a problem hiding this comment.
Yes totally The is the issue #69460 Will add a comment as well.
seemethere
reviewed
Dec 13, 2021
| enable_force_on_cpu_test=1, | ||
| ciflow_config=CIFlowConfig( | ||
| run_on_canary=True, | ||
| labels={LABEL_CIFLOW_DEFAULT, LABEL_CIFLOW_CUDA, LABEL_CIFLOW_WIN} |
There was a problem hiding this comment.
Can we make this a periodic job as well? And remove LABEL_CIFLOW_DEFAULT from here?
There was a problem hiding this comment.
Ah yes totally let me do this
malfet
approved these changes
Dec 13, 2021
janeyx99
approved these changes
Dec 13, 2021
seemethere
approved these changes
Dec 13, 2021
|
@atalman has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Unfortunately looks like this was causing upstream windows failures: From https://github.com/pytorch/pytorch/runs/4515996378?check_suite_focus=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69081